perf: use deque for BFS queue in get_function_dependency()#1952
Open
giulio-leone wants to merge 1 commit intoFoundationAgents:mainfrom
Open
perf: use deque for BFS queue in get_function_dependency()#1952giulio-leone wants to merge 1 commit intoFoundationAgents:mainfrom
giulio-leone wants to merge 1 commit intoFoundationAgents:mainfrom
Conversation
giulio-leone
requested a deployment
to
unittest
GitHub Actions
Waiting
giulio-leone
force-pushed
the
fix/sanitize-bfs-deque-performance
branch
from
cb8fc8a to
6efe21e
Compare
giulio-leone
requested a deployment
to
unittest
GitHub Actions
Waiting
get_function_dependency() traverses the call graph via BFS using list.pop(0), which is O(n) per removal. Switch to collections.deque with popleft() for O(1).
giulio-leone
force-pushed
the
fix/sanitize-bfs-deque-performance
branch
from
6efe21e to
d9fba73
Compare
giulio-leone
requested a deployment
to
unittest
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_function_dependency()traverses the call graph via BFS usinglist.pop(0), which is O(n) per removal. For large call graphs this makes traversal O(n²).Solution
Switch to
collections.dequewith.popleft()for O(1) front removal.Changes
metagpt/utils/sanitize.py: Importdeque, init queue asdeque([entrypoint]), use.popleft()Testing
ast.parse()