Add support for prepared statements in JDBC #3116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohadzeliger
changed the title
# Conflicts: # yaml-tests/src/test/java/JDBCYamlIntegrationTests.java
…t type mismatch in array.
ScottDugas
requested changes
Feb 11, 2025
| case Types.DOUBLE: | ||
| return column.getDouble(); | ||
| default: | ||
| // TODO: NULL? |
There was a problem hiding this comment.
"enum" is also missing from this, but enum support in general is awaiting: #3074
There was a problem hiding this comment.
Is #3074 going to be merged in soon? If so, I can add support here after it was merged.
There was a problem hiding this comment.
#3074 merged, but I don't know that we need to add support here, now.
fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
Show resolved
Hide resolved
fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
Show resolved
Hide resolved
fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
Outdated
Show resolved
Hide resolved
fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
Outdated
Show resolved
Hide resolved
fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/JDBCArrayImpl.java
Show resolved
Hide resolved
fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/JDBCArrayImpl.java
Show resolved
Hide resolved
fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/ParameterHelper.java
Outdated
Show resolved
Hide resolved
fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/ParameterHelper.java
Show resolved
Hide resolved
# Conflicts: # yaml-tests/src/test/java/YamlIntegrationTests.java
…here needed for old server support
ScottDugas
requested changes
Feb 12, 2025
fdb-relational-grpc/src/main/java/com/apple/foundationdb/relational/jdbc/TypeConversion.java
Show resolved
Hide resolved
| case Types.DOUBLE: | ||
| return column.getDouble(); | ||
| default: | ||
| // TODO: NULL? |
There was a problem hiding this comment.
#3074 merged, but I don't know that we need to add support here, now.
| @@ -58,6 +58,7 @@ test_block: | |||
| - | |||
| # correlation are allowed in from-subquery. | |||
| - query: select x, sq.idr, sq.nr from a, (select * from r where r.idr = a.x) sq; | |||
| - supported_version: !current_version # changes in Proto definition for arrays | |||
fdb-relational-jdbc/src/main/java/com/apple/foundationdb/relational/jdbc/JDBCArrayImpl.java
Show resolved
Hide resolved
ScottDugas
approved these changes
Feb 13, 2025
|
ohadzeliger
pushed a commit
to ohadzeliger/fdb-record-layer
that referenced
this pull request
Feb 13, 2025
…tement multi-version tests to run against the 4.0.459 release
|
2 similar comments
|
|
|
1 similar comment
|
ScottDugas
pushed a commit
that referenced
this pull request
Feb 14, 2025
Backport parts of PR #3116 in order to allow prepared statement multi-version tests to run against the 4.0.459 release. This only takes in the JDBC server pieces that are required to allow prepared statement to run on JDBC, so that newer versions of the project can test against this server to prove backwards compatibility. The original PR had additional changes to the client side that are not required for this purpose and so were left out of this PR. Co-authored-by: Pranjal Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for prepared statements on the JDBC server.
Specifically, support for PreparedStatement
setObject()andsetArray().Also,
JDBCRelationalConnectionneeded support for array creation.A slew of type conversion utilities were added in support of these features.
In general, we have 3 models that we are dealing with:
And because of the way the API is structured, we may need to perform conversions between all 3. Specifically, we support the following:
Connection.createArrayOf, where the type of array elements is also providedArrayandStructare assumed in all cases of nesting. That is, an array of elements would be assumed to have SQLArrayif there is any nested array. The reasoning is that we would need the additional type information in these casesSome cleanup and restructuring of that code may be warranted, in addition to null, error and edge case testing.
The protobuf for the
Arraydefinition was changed in order to support the extra type information.The change was made to be backwards compatible at the protobuf level but the old server (before this change) cannot handle arrays in parameters. In order to facilitate multi-version testing against the older servers we may be able to cherry-pick these commits to the server's branch.