Support unsetting transaction-bound SchemaTemplate in a Transaction #3496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g31pranjal
added
enhancement
g31pranjal
force-pushed
the
unset_txn_bound_schema_template
branch
from
cbc8517 to
300da3a
Compare
g31pranjal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for "unsetting" a transaction-bound SchemaTemplate from the ongoing transaction. This is essential if we want to revert the execution to using the SchemaTemplate from the catalog thereby undoing all the temporary function definitions at once. Note that this could be more efficient than the
DROP TEMPORARY FUNCTION ...DDL introduced in the previous PR and have the wider scope that is beyondTEMPORARY FUNCTIONSdefinitions.Also added a test for testing it in the context of
TransactionBoundDatabase.