-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FreeCAD snap to core24 #123
base: master
Are you sure you want to change the base?
Conversation
Update to latest platform and build snap versions as described on https://snapcraft.io/docs/kde-neon-extension
What's delaying this ? (1.0 release?) |
Last time I tried a build with these changes, it failed. The |
The build error: https://github.com/furgo16/FreeCAD-snap/actions/runs/11372445768/job/31636779466#step:4:1215
@ScarlettGatelyMoore I see that you've helped with the FreeCAD snap in the past. Would you happen to know why this build error is happening when upgrading the kde-neon extension? Thanks! |
Why KDE Neon and not Plasma ? or are you making a separate option for Neon ? |
So sorry, Our ability to update qt5 content packs was removed for awhile. I am however making new ones as we speak. Are you still qt5 or qt6? I can help, but not til Monday I am afraid. |
@ScarlettGatelyMoore thank you! Monday, or in your own time, would be fine. We're just glad to get any help or advice at all! The upcoming FreeCAD 1.0 release will still be on Qt5, which is the priority for this snap, and what we want to have in shape for now. However, FreeCAD builds with Qt6, and at some point we'd like to have an additional Qt6 snap build for testers. Given that FreeCAD is a Qt, but not KDE app, is it worth keeping going the
@luzpaz check out https://snapcraft.io/docs/supported-extensions and the links in the issue description. If I understand it correctly, |
I maintain both the kde-neon and kde-neon-6 extension as well as qt snaps. The problem is the lack of qt5 snaps due to reason out of my control. This is now fixed and I am working on them. Will be here tomorrow to get this sorted. |
Still working on the content snaps, I will then need to update snapcraft to use them. |
@ScarlettGatelyMoore thanks! Is there anything we can do to help? Could you point us to the source code of the content/platform and SDK snaps? |
Hi, the documentation is here https://community.kde.org/Guidelines_and_HOWTOs/Snap |
Core24 support awaits canonical/snapcraft#5092 I will also have to do similiar with kde-neon for qt5. But for now we can do core22 as it will be a much smaller PR and merged quicker. |
Content packs are done. I have added qt5 support to canonical/snapcraft#5092 now I just need them to merge. Thanks for your patience. |
@ScarlettGatelyMoore thank you. I've subscribed to the snapcraft PR, but I must admit I'm a bit lost as to how this will affect us. We would appreciate some guidance for our use case (the upcoming FreeCAD 1.0 release, Qt5-based)? I.e.:
Thanks! |
@ScarlettGatelyMoore have you had the chance of looking at the questions in the previous comment? Thanks! |
Gosh sorry I missed the question. I am in the hospital with on going issues and infection of broken arm. Once that pr is merged and snapcraft is released, you can move to core24. You can move to qt6 now by using kde-neon-6 extension. I honestly don't know why canonical/snapcraft#5092 is taking so long. Sorry. |
canonical/snapcraft#5092 has now been merged 🎉. I'll be watching https://github.com/canonical/snapcraft/releases to see when the changes will be available. Hopefully soon in a future Snapcraft 8.5.2. @ScarlettGatelyMoore I hope you're doing well and thanks for the help so far! In the meantime, would you be able to guide us through the changes needed in this PR to first update our FreeCAD Qt5 snap to Thanks! |
I am doing better thank you! I am also watching for the release and will absolutely help get this to core24 :) |
Glad to hear @ScarlettGatelyMoore ! |
@ScarlettGatelyMoore I see that Snapcraft 8.6 has been released 🎉 What are the next steps to update our FreeCAD Qt5 snap to core24? Your guidance here would be really valuable. Thanks! |
I will do a PR for this. Is https://github.com/FreeCAD/freecad-deps-core22-snap/tree/master Still used? |
I've not dealt with the dependencies code before. There are two repos:
Creating a |
I'd be happy to create a core24 branch. Edit: done 👉 https://github.com/FreeCAD/freecad-deps-snap/tree/core24 |
@ScarlettGatelyMoore excellent, thanks! Now that we have your PR with the dependencies, would you mind reviewing this PR as well? I'd be interested to know if the Previously the |
(FYI I merged that PR for core24 -- thanks again, @ScarlettGatelyMoore) |
@chennes thanks! Do I see it correctly that https://github.com/FreeCAD/freecad-deps-snap/commits/core24/ is missing some commits from https://github.com/FreeCAD/freecad-deps-snap/commits/core22? Do those commits need to be ported to the |
@furgo16 there are several changes that will need to be made. Content snaps are not versioned, env vars changed and newer dependencies. I was going to do a pr. As far as the dependencies snap, it is good, I have built it locally and updated the above changes for core24. Please don't bring back changes from that core22 repo. Thanks. If you commit this I can do a pr for the remaining changes. |
@chennes thinking about it, since the daily builds are built from Could you perhaps create a |
Update to latest platform and build snap versions as described on https://snapcraft.io/docs/kde-neon-extension
Ultimately, I'd like to:
snapcraft extensions
lists the supported base snap to be up tocore22
for both thekde-neon
andkde-neon-6
snapskde-neon-6
extensionResearch