Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild formula for linux and use python3 var instead of hard coded name #516

Closed

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented May 22, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch self-assigned this May 22, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented May 22, 2024

current build issues on macos,

 /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries/libGLU.tbd -framework CoreFoundation -framework CoreGraphics /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries/libGL.tbd
ld: Undefined symbols:
  _CGLChoosePixelFormat, referenced from:
      cglglue_context_create_pbuffer(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_software(cglglue_contextdata*) in gl_cgl.cpp.o
  _CGLCreateContext, referenced from:
      cglglue_context_create_pbuffer(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_software(cglglue_contextdata*) in gl_cgl.cpp.o
  _CGLDestroyContext, referenced from:
      cglglue_contextdata_cleanup(cglglue_contextdata*) in gl_cgl.cpp.o
  _CGLDestroyPixelFormat, referenced from:
      cglglue_contextdata_cleanup(cglglue_contextdata*) in gl_cgl.cpp.o
  _CGLErrorString, referenced from:
      cglglue_context_create_pbuffer(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_pbuffer(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_pbuffer(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_software(cglglue_contextdata*) in gl_cgl.cpp.o
      cglglue_context_create_software(cglglue_contextdata*) in gl_cgl.cpp.o
      _cglglue_context_make_current in gl_cgl.cpp.o
      _cglglue_context_make_current in gl_cgl.cpp.o
      _cglglue_context_make_current in gl_cgl.cpp.o
      ...
  _CGLGetVirtualScreen, referenced from:
      _cglglue_context_make_current in gl_cgl.cpp.o
  _CGLSetOffScreen, referenced from:
      cglglue_context_create_software(cglglue_contextdata*) in gl_cgl.cpp.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libCoin.80.0.2.dylib] Error 1
make[1]: *** [src/CMakeFiles/Coin.dir/all] Error 2
make: *** [all] Error 2

@ipatch ipatch force-pushed the coin3d_py310-rebottle.for.linux branch from eda36fc to bb1fdcc Compare May 22, 2024 17:47
@ipatch
Copy link
Collaborator Author

ipatch commented May 22, 2024

the above issue has been resolved i believe was related to the default std_cmake_args provided by homebrew in that it was using CLT for macos as opposed to the entire Xcode.app bundled SDK. (not 100% certain) but none the less the build issue seems to be resolved.

@ipatch ipatch added the pr-pull label May 22, 2024
@github-actions github-actions bot closed this in 384d354 May 22, 2024
@ipatch ipatch deleted the coin3d_py310-rebottle.for.linux branch May 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant