Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]_py310: update post_install steps ipatch/homebrew-freecad #634

Closed

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Nov 10, 2024

this is an attempt to update the post_install step for the freecad formula to resolve the proxy pyside runtime issues.

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch changed the title [email protected]_py310: update post_install steps [email protected]_py310: update post_install steps ipatch/homebrew-freecad Nov 10, 2024
@ipatch ipatch self-assigned this Nov 10, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Nov 10, 2024

see ongoing notes in #630

@ipatch ipatch force-pushed the [email protected]_py310-updates branch 4 times, most recently from 3937e5b to 2587111 Compare November 11, 2024 18:30
@ipatch
Copy link
Collaborator Author

ipatch commented Nov 11, 2024

awesome 🥳, with the latest commit in the test.yml file, it appears homebrew test-bot is no longer removing all the necessary installed formula to build freecad on the self-hosted runner running ubuntu-22.04 if the job fails.

https://github.com/FreeCAD/homebrew-freecad/actions/runs/11784195535/job/32823261029?pr=634

https://github.com/FreeCAD/homebrew-freecad/blob/f4aa913f95b8887913e07b885d0ae2c547a4077f/.github/workflows/tests.yml

@ipatch
Copy link
Collaborator Author

ipatch commented Nov 11, 2024

current build error on self-hosted runner that will require manual intervention after other build tasks have finished.

Run brew test-bot --only-setup
==> Using Homebrew/homebrew-test-bot fadb62c (Merge pull request #1298 from Homebrew/dependabot/github_actions/ruby/setup-ruby-1.201.0)
==> Using Homebrew/brew 4.4.5-2-g1cb90c6005 (Merge pull request #18741 from Homebrew/tap_auditor-renames-exist)
==> Using Homebrew/homebrew-core d068a6dfa1a (Merge pull request #197194 from Homebrew/bump-cyphernetes-0.14.0)
==> Testing FreeCAD/homebrew-freecad 8298de8 (Merge 65a977bc215609f59e52cddd42ef21266d479a47 into 84e74a85c46c8fad1033f8a922f1cbaa4f6fc915):

==> Running Setup#run!
==> brew install-bundler-gems --add-groups=ast,audit,bottle,formula_test,livecheck,style
==> brew config
HOMEBREW_VERSION: 4.4.5-2-g1cb90c6
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1cb90c600546f82d67e6950d90d2073ecc32114d
Last commit: 3 hours ago
Core tap HEAD: d068a6dfa1ad2ce79b31e58949cc5a3ac5adfc1f
Core tap last commit: 2 days ago
Core tap JSON: 11 Nov 20:30 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_BOOTSNAP: set
HOMEBREW_CACHE: /home/linuxbrew/.linuxbrew/cache
HOMEBREW_CASK_OPTS: []
HOMEBREW_COLOR: set
HOMEBREW_CURL_PATH: /usr/bin/curl
HOMEBREW_DEVELOPER: set
HOMEBREW_DISPLAY: localhost:10.0
HOMEBREW_EDITOR: nvim
HOMEBREW_FAIL_LOG_LINES: 150
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_GIT_EMAIL: [email protected]
HOMEBREW_GIT_NAME: BrewTestBot
HOMEBREW_GIT_PATH: /usr/bin/git
HOMEBREW_LOGS: /opt/code/hbfc-ar/_work/homebrew-freecad/homebrew-freecad/logs
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_ANALYTICS: set
HOMEBREW_NO_AUTOREMOVE: set
HOMEBREW_NO_AUTO_UPDATE: set
HOMEBREW_NO_EMOJI: set
HOMEBREW_NO_ENV_HINTS: set
HOMEBREW_NO_GITHUB_API: set
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: set
HOMEBREW_NO_INSTALL_CLEANUP: set
HOMEBREW_SORBET_RUNTIME: set
HOMEBREW_TEMP: /home/brewer/tmp/homebrew
Homebrew Ruby: 3.3.6 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: octa-core 64-bit haswell
Clang: 19.1.3
Git: 2.34.1 => /usr/bin/git
Curl: 7.81.0 => /usr/bin/curl
Kernel: Linux 6.8.0-48-generic x86_64 GNU/Linux
OS: Ubuntu 22.04.5 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.4.0
/usr/bin/ruby: 3.0.2
glibc: N/A
gcc@11: N/A
gcc: 14.2.0_1
xorg: N/A
==> brew doctor
==> FAILED
Full doctor output
  Please note that these warnings are just used to help the Homebrew maintainers
  with debugging if you file an issue. If everything you use Homebrew for is
  working fine: please don't worry or file an issue; just ignore this. Thanks!
  
  Warning: Some installed formulae are missing dependencies.
  You should `brew install` the missing dependencies:
    brew install libtommath
  
  Run `brew missing` for more details.
  
Error: 1 failed step!
brew doctor
Error: Process completed with exit code 1.

@ipatch ipatch added the pr-pull label Nov 11, 2024
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
@ipatch ipatch closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant