Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to SQLite (over PostgreSQL) #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default to SQLite (over PostgreSQL) #35

wants to merge 1 commit into from

Conversation

macro1
Copy link
Member

@macro1 macro1 commented Dec 16, 2014

Fixes #33

Working on this I released that README.rst is out of date, and that lxml is not a non-trivial dependancy we added with scraping. I made #34 to address that in a similar way.

@@ -0,0 +1 @@
psycopg2==2.5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer to add a -r requirements.txt line here instead of listing two requirements files in the pip install.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements can only be specified once, even if they don't conflict. If I add the general requirements here, it will prevent this requirement file from being combined in the same install command as dev-requirements.txt.

What we could do is have a folder with the different types of requirements, and these top-level files would just combine them.

Edit: What I meant is specific package requirements can only be specified once, you can use multiple requirement files in the same installation command as I've done in both the CI and deploy configuration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to support prod-requirements.txt and dev-requirements.txt in the same command.

The convention of importing a base requirements file seems to be very common. It's the way Two Scoops does it: https://github.com/twoscoops/django-twoscoops-project/blob/develop/requirements/production.txt

I haven't seen the convention of splitting requirements and installing multiple requirements at once. It's possible I overlooked it somewhere though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SQLite for local development
2 participants