Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to add/edit similar artists #61

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

treyhunner
Copy link
Contributor

  • Add artist page
  • Add page for user to edit artist
  • Add page for user to edit/add artist similarities

This is a work-in-progress and still broken.
import Ember from 'ember';
import AuthenticatedRouteMixin from 'simple-auth/mixins/authenticated-route-mixin';

export default Ember.Route.extend(AuthenticatedRouteMixin, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This AuthenticatedRouteMixin makes /artists/163/similarities redirect to the login page when the user isn't authenticated. However, after login the user is taken to the homepage instead of back to the previous /artists/163/similarities page. I'm not sure how to fix that yet.

@treyhunner
Copy link
Contributor Author

I'm trying to get the /artists/163/similarities page to work.

I want the form rows to work like so:

  1. Similarities will be saved to the server as the user types (already works for existing models via PUT)
  2. There should always be one blank row at the end representing a new similarity. If the user enters data it should be saved to the server and a new blank row should be added.

An example of how it should work: http://jsfiddle.net/treyh/kfffyqup/

Part 1 works already but part 2 doesn't work yet.

@treyhunner treyhunner changed the title [WIP] Allow users to add/edit similar artists Allow users to add/edit similar artists Nov 11, 2014
@treyhunner
Copy link
Contributor Author

The tests haven't been updated/added, but this seems to work now. You can get to artist pages by clicking the pencil icon in the top right of an artist's search result listing. From that page there's a link to a page for adding/updating your artist similarity ratings (you need to be logged in for that).

See here: http://freemusic.ninja/artists?name=They%20Might%20Be%20Giants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant