-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to add/edit similar artists #61
base: master
Are you sure you want to change the base?
Conversation
fd4bc90
to
e690404
Compare
This is a work-in-progress and still broken.
e690404
to
661db73
Compare
661db73
to
2b88625
Compare
import Ember from 'ember'; | ||
import AuthenticatedRouteMixin from 'simple-auth/mixins/authenticated-route-mixin'; | ||
|
||
export default Ember.Route.extend(AuthenticatedRouteMixin, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This AuthenticatedRouteMixin
makes /artists/163/similarities
redirect to the login page when the user isn't authenticated. However, after login the user is taken to the homepage instead of back to the previous /artists/163/similarities
page. I'm not sure how to fix that yet.
I'm trying to get the I want the form rows to work like so:
An example of how it should work: http://jsfiddle.net/treyh/kfffyqup/ Part 1 works already but part 2 doesn't work yet. |
This avoids a false positive when testing whether the buffered proxy has changed.
The tests haven't been updated/added, but this seems to work now. You can get to artist pages by clicking the pencil icon in the top right of an artist's search result listing. From that page there's a link to a page for adding/updating your artist similarity ratings (you need to be logged in for that). See here: http://freemusic.ninja/artists?name=They%20Might%20Be%20Giants |
Add page for user to edit artist