Move windows headers to port.c

[creiter64]

Move windows header files to port.c

Description

This prevents the inclusion of windows.h. into all header files using FreeRTOS.h and thus defining several macros conflicting with common definitions. This is a more minimal fix compared to #1282

Test Steps

None, just a build issue.

Checklist:

• I have tested my changes. No regression in existing tests.
• I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[creiter64]

I have removed some of the overly complicated task selection code. It would be good if someone knowledgeable could review it.

[aggarg]

This prevents the inclusion of windows.h. into all header files using FreeRTOS.h and thus defining several macros conflicting with common definitions.

Would you please share the conflicting definitions?

[creiter64]

Would you please share the conflicting definitions?

In my case, windows.h included winbase.h which in turn contains a macro defined as BAUD_9600, which conflicted with an enum in my code.

[aggarg]

In my case, windows.h included winbase.h which in turn contains a macro defined as BAUD_9600, which conflicted with an enum in my code.

Is it not possible to change the name of this enum?

[creiter64]

Is it not possible to change the name of this enum?

No. In addition I'd argue that it's bad practice to force the user to know all the ways windows.h messes with their defines on a cross-platform OS like FreeRTOS.

[aggarg]

In addition I'd argue that it's bad practice to force the user to know all the ways windows.h messes with their defines on a cross-platform OS like FreeRTOS.

If you want to run your application on Windows, using a name that is used by Windows OS can lead to potential conflicts. For example, what if a future Windows update moves this define to intrin.h, which could break your application.

I assume that you have constraints preventing you from renaming the enum, but I would recommended renaming it for robustness.

[creiter64]

I'm not using anything from the Windows API so I was suprised that FreeRTOS was publicly including it. The windows build is for unit testing of an embedded firmware. I try to keep that standard C compliant as possible.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud