Skip to content

STM32 network interface bug fixes #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

STM32 network interface bug fixes #1253

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5456fa2
Removing traceISR_ENTER()
May 23, 2025
0c33755
Removed warning and assert for STM32F7
May 23, 2025
0cdb485
Merge branch 'main' into stm32-networkinterface-bugfixes
tony-josi-aws Jun 2, 2025
4e3ba1b
Merge branch 'main' into stm32-networkinterface-bugfixes
tony-josi-aws Jun 12, 2025
9402542
Merge branch 'main' into stm32-networkinterface-bugfixes
tony-josi-aws Jun 27, 2025
e0882da
Merge branch 'main' into stm32-networkinterface-bugfixes
tony-josi-aws Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions source/portable/NetworkInterface/STM32/NetworkInterface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@

#if ipconfigIS_DISABLED( ipconfigPORT_SUPPRESS_WARNING )

#if defined( niEMAC_STM32FX ) && defined( ETH_RX_BUF_SIZE )
#warning "As of F7 V1.17.1 && F4 V1.28.0, a bug exists in the ETH HAL Driver where ETH_RX_BUF_SIZE is used instead of RxBuffLen, so ETH_RX_BUF_SIZE must == niEMAC_DATA_BUFFER_SIZE"
#if defined( niEMAC_STM32FX ) && defined( ETH_RX_BUF_SIZE ) && defined( STM32F4 )
#warning "As of F4 V1.28.0, a bug exists in the ETH HAL Driver where ETH_RX_BUF_SIZE is used instead of RxBuffLen, so ETH_RX_BUF_SIZE must == niEMAC_DATA_BUFFER_SIZE"
#endif

#if ipconfigIS_DISABLED( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM )
Expand Down Expand Up @@ -982,7 +982,7 @@ static BaseType_t prvEthConfigInit( ETH_HandleTypeDef * pxEthHandle,
pxEthHandle->Init.RxBuffLen = niEMAC_DATA_BUFFER_SIZE;
/* configASSERT( pxEthHandle->Init.RxBuffLen <= ETH_MAX_PACKET_SIZE ); */
configASSERT( pxEthHandle->Init.RxBuffLen % 4U == 0 );
#if ( defined( niEMAC_STM32FX ) && defined( ETH_RX_BUF_SIZE ) )
#if ( defined( niEMAC_STM32FX ) && defined( ETH_RX_BUF_SIZE ) && defined( STM32F4 ) )
configASSERT( pxEthHandle->Init.RxBuffLen == ETH_RX_BUF_SIZE );
#endif

Expand Down Expand Up @@ -1785,8 +1785,6 @@ static BaseType_t prvAcceptPacket( const NetworkBufferDescriptor_t * const pxDes

void ETH_IRQHandler( void )
{
traceISR_ENTER();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traceISR_ENTER is part of the trace macros that got added to FreeRTOS kernel with FreeRTOS/FreeRTOS-Kernel#659

The change is part of the Kernel V11.0.0 and above.

I would suggest keeping it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I see

#ifndef traceISR_ENTER
    #define traceISR_ENTER()
#endif

What if I upgrade my +TCP and keep on using an older kernel?

 void ETH_IRQHandler( void )
 {
+
+    #if defined( traceISR_ENTER )
+        /* The following macro is defined in FreeRTOS.h
+         * in kernels "V11.2.0" or higher. */
+        traceISR_ENTER();
+    #endif

     ETH_HandleTypeDef * pxEthHandle = &xEthHandle;

Hi @ldehenni, thanks for you PR.

What about the above code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HTRamsey , are you OK with this PR?

@tony-josi-aws , shall we add a default declaration like:

+    #if defined( traceISR_ENTER )
+        /* The following macro is defined in FreeRTOS.h
+         * in kernels "V11.2.0" or higher. */
+        traceISR_ENTER();
+    #endif

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me


ETH_HandleTypeDef * pxEthHandle = &xEthHandle;

xSwitchRequired = pdFALSE;
Expand Down