Fix logic for grouping consecutive points in CountriesAndCities #610
Conversation
This update corrects the logic for grouping consecutive points in the group_points_with_consecutive_cities method. It ensures sessions are properly split when transitioning between cities or encountering significant time gaps, leading to accurate grouping and filtering of points based on session duration.
Update to check the fixed logic
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic for grouping consecutive points by addressing inconsistencies in the session splitting mechanism in the CountriesAndCities service. Key changes include updating the test cases in the spec file to reflect the new expected behavior, modifying the call method to only include countries with valid sessions, and introducing a new grouping method for consecutive points.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/services/countries_and_cities_spec.rb | Updated test cases with revised expectations and point data |
| app/services/countries_and_cities.rb | Revised session grouping logic and filtering implementation |
|
|
||
| build_city_data(city, points_count, timestamps, duration) | ||
| # Split session if city changes or time gap exceeds the threshold | ||
| if point.city != prev_point.city |
There was a problem hiding this comment.
The session splitting condition checks only for a change in city, but the comment indicates that sessions should also split when a time gap exceeds a threshold. Consider adding a condition to compare the time difference between the current point and the previous point.
| if point.city != prev_point.city | |
| if point.city != prev_point.city || (point.timestamp - prev_point.timestamp) > MAX_TIME_GAP |
Copilot uses AI. Check for mistakes.
This update corrects the logic for grouping consecutive points in the group_points_with_consecutive_cities method. It ensures sessions are properly split when transitioning between cities or encountering significant time gaps, leading to accurate grouping and filtering of points based on session duration.
This problem had citys showning up in the list that were driven through with over an apart but points not consequtively in that city.