[Fix] Bug in example prediction for Arsenal vs. Manchester City#4
Open
lyonjust wants to merge 2 commits intoFriends-of-Tracking-Data-FoTD:masterfrom
Open
[Fix] Bug in example prediction for Arsenal vs. Manchester City#4lyonjust wants to merge 2 commits intoFriends-of-Tracking-Data-FoTD:masterfrom
lyonjust wants to merge 2 commits intoFriends-of-Tracking-Data-FoTD:masterfrom
Conversation
Update 11SimulateMatches.py
Author
|
Note - the bug exists only in the example of Man City v Arsenal. It does not repeat in the function simulate_match later in the script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a small bug in the example prediction of Arsenal (away team) v Man City (home team).
The Arsenal scoring rate (away_score_rate) is erroneously modelled as if Arsenal is also playing at home. This leads to the predicted goals being overstated.