fix(backend): category/settings page fixes - #88
Open
skerbis wants to merge 2 commits into
Open
Conversation
This was referenced Aug 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR is the second stacked step for #86 and focuses on backend adjustments around the category/settings pages and the hide_categories layer, aligning page controllers with the new namespaced class layout introduced in the core baseline.
Changes:
- Updates backend page entrypoints (
pages/*) to reference the new namespaced page controller classes. - Refines metainfo sidebar rendering to wrap the form in a PJAX container and hardens article lookups.
- Refactors category settings form inputs and tightens typing/handling across category-related backend helpers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pages/settings.php | Imports the namespaced settings page controller class. |
| pages/content.metainfo.php | Avoids null dereference on missing articles and wraps metainfo form in a PJAX container. |
| pages/categories.php | Imports the namespaced categories page controller class. |
| lib/pages/page_settings.php | Adds namespace/imports and simplifies metainfo settings handling with backward-compatible config fallback. |
| lib/pages/page_categories.php | Adds namespace/imports, adds stricter typing, and refactors category/article selection UI. |
| lib/hide_categories.php | Adds namespace/imports, uses CSP nonces for injected scripts, and replaces DOM parsing approach for option removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Addressed Copilot review comments in follow-up commit
Also rebased top stack branch ( |
skerbis
force-pushed
the
stack/02-backend
branch
from
August 11, 2026 15:32
7f5b491 to
1f6a4ca
Compare
skerbis
force-pushed
the
stack/02-backend
branch
from
August 12, 2026 18:31
1f6a4ca to
4ceef43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of stacked PRs for #86.
Depends on: #87
Scope:
hide_categoriesfocused fix layerSolved issues:
How and why:
selectpicker+ Live-Search) aktiviert und beim Seiten-Load robust initialisiert.pageCategories()wird wieder zuverlässig aufrex:readyausgeführt, sodass Feldsichtbarkeiten korrekt reagieren.hide_categories:Base:
stack/01-coreNext stacked PR:
stack/03-docs