Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set min memory limit to 256 mb #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: set min memory limit to 256 mb #305

wants to merge 1 commit into from

Conversation

shyim
Copy link
Member

@shyim shyim commented Dec 19, 2024

having 512mb per each web request is normally too much

@shyim shyim requested a review from tinect December 19, 2024 14:56
@tinect
Copy link
Member

tinect commented Dec 19, 2024

But 512m fits Shopwares announced requirements 🤔

@ArthurErlich
Copy link

I would also say that 256 MB is really low.

For most of the shops I’ve created or worked with, the limit was set to 2 GB or more, even for smaller shops.

@shyim
Copy link
Member Author

shyim commented Dec 22, 2024

Maybe the workers need so much memory, but the regular web requests should not be more than ~120 mb in default without plugins 🤔

@schneider-felix
Copy link
Member

I totally agree that you should try to keep the memory limit as low as possible. However since we can't even agree on the right memory limit here, I think that we should just stick with Shopware's system requirements for now: https://developer.shopware.com/docs/guides/installation/requirements.html

Maybe, we could also check the memory limit against a range. For example: memory_limit >= 256 && memory_limit <=512.

@tinect
Copy link
Member

tinect commented Dec 29, 2024

What about removing the check or just change it to an info.
This is more project related, isn‘t it?

@ArthurErlich
Copy link

ArthurErlich commented Dec 29, 2024

I think the memory limit should still be there. Just use the minimum requirement from Shopware.

It may also be interesting to see how many workers are currently running and how much memory is being used per worker or total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants