Skip to content

Add support for opening remote files with local app by copying them over first #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fuco1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for opening remote files with local app by copying them over first #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions dired-open.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,29 @@ string as well."
(set-process-query-on-exit-flag process nil))
process))

(defcustom dired-open-remote-file-regex-list nil
"List of regular expressions for files which should be copied
to local machine before trying to open."
:type '(repeat regexp)
:group 'dired-open)

(defun dired-open--pull-remote-file (file)
"Decide if we want to pull remote (tramp) FILE to local machine.

In some cases such as opening html files in a browser it makes no
sense to use the remote path, so pull the file to local machine
and open that file instead.

This functions provides a generic interface for that."
(if (and (file-remote-p file)
(--any (string-match-p it file) dired-open-remote-file-regex-list))
(progn
(mkdir (concat temporary-file-directory "dired-open") t)
(let ((tmp-file (make-temp-file "dired-open/tmp")))
(copy-file file tmp-file t)
tmp-file))
file))


;;; file opening procedures
(defun dired-open-xdg ()
Expand All @@ -164,7 +187,9 @@ string as well."
(if (executable-find "xdg-open")
(let ((file (ignore-errors (dired-get-file-for-visit))))
(start-process "dired-open" nil
"xdg-open" (file-truename file)))
"xdg-open"
(dired-open--pull-remote-file
(file-truename file))))
nil))

(defun dired-open-by-extension ()
Expand All @@ -179,7 +204,9 @@ The mappings from extensions to applications is specified by
(not (file-directory-p file)))
(--each-while dired-open-extensions (not process)
(when (string-match-p (concat "\\." (regexp-quote (car it)) "\\'") file)
(setq process (dired-open--start-process file (cdr it)))))
(setq process (dired-open--start-process
(dired-open--pull-remote-file file)
(cdr it)))))
process)))

(defun dired-open-guess-shell-alist ()
Expand All @@ -192,7 +219,9 @@ The mappings from extensions to applications is specified by
(not (file-directory-p file)))
(--each-while dired-guess-shell-alist-user (not process)
(when (string-match-p (car it) file)
(setq process (dired-open--start-process file (eval (cadr it)))))))
(setq process (dired-open--start-process
(dired-open--pull-remote-file file)
(eval (cadr it)))))))
process))

(defun dired-open-call-function-by-extension ()
Expand Down