Related to issue #216 #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added validation for Ethereum addresses using the EIP-55 checksum standard. - Implemented the `validate_eth_address` function to ensure all Ethereum addresses are correctly validated before use. - Updated the `Account::new` constructor to include checksum validation logic. - Included test cases to verify the correctness of valid and invalid Ethereum addresses. - Improved error handling for invalid addresses.
|
|
sdankel
reviewed
Mar 25, 2025
| /// | ||
| /// # Returns | ||
| /// * `Result<Account, &'static str>` - Returns an Account if the address is valid, or an error message otherwise. | ||
| pub fn new(index: Option<usize>, unverified: Unverified, cmd: Option<Command>) -> Result<Self, &'static str> { |
There was a problem hiding this comment.
This isn't called from anywhere.
sdankel
requested changes
Mar 25, 2025
| } | ||
|
|
||
| // Example test cases for Ethereum address validation |
There was a problem hiding this comment.
Why are they example test cases?
|
Please update the title to something meaningful and link the issue in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate_eth_addressfunction to ensure all Ethereum addresses are correctly validated before use.Account::newconstructor to include checksum validation logic.