Added Wallet Export Functionality #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @adirola to sign the Fuel Labs Contributor License Agreement. |
|
@kayagokalp here is the PR for export functionality |
sdankel
reviewed
Mar 25, 2025
Comment on lines
+12
to
+14
| /// Forces export even if it might be unsafe | ||
| #[clap(short, long)] | ||
| pub force: bool, |
There was a problem hiding this comment.
It doesn't look like this is used anywhere. What does this mean?
Suggested change
| /// Forces export even if it might be unsafe | |
| #[clap(short, long)] | |
| pub force: bool, |
Comment on lines
+15
to
+17
| /// How many accounts to cache by default (Default 10) | ||
| #[clap(short, long)] | ||
| pub cache_accounts: Option<usize>, |
There was a problem hiding this comment.
Let's use clap to set the default
Suggested change
| /// How many accounts to cache by default (Default 10) | |
| #[clap(short, long)] | |
| pub cache_accounts: Option<usize>, | |
| /// The number of accounts to cache | |
| #[clap(long, default_value = 10)] | |
| pub cache_accounts: usize, |
| } | ||
|
|
||
| /// Securely wipes sensitive data from memory | ||
| fn secure_wipe(data: &mut [u8]) { |
There was a problem hiding this comment.
Good idea! We should use zeroize instead to make sure this isn't optimized away by the compiler.
| fn test_export_wallet() { | ||
| with_tmp_dir_and_wallet(|_dir, wallet_path| { | ||
| let result = export_wallet(&wallet_path, TEST_PASSWORD); | ||
| assert!(result.is_ok()); |
| assert!(result.is_ok()); | ||
|
|
||
| if let Ok(phrase) = result { | ||
| assert!(!phrase.is_empty()); |
There was a problem hiding this comment.
We should assert that it's the test mnemonic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export command will request the password to unlock the wallet to derive the wallet mnemonic which is rendered on alternamte screen and the buffer is cleared. The derived addresses will be stored in cache.
Linked to PR : #222