-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: Update fuels and other dependencies #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
previously approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for this one. I just left a question to understand whether bump was intended for this PR or not
JoshuaBatty
approved these changes
Mar 25, 2025
zees-dev
reviewed
Mar 25, 2025
|
||
/// Returns a mock provider with a mock fuel-core server that responds to the nodeInfo graphql query. | ||
/// Note: the raw JSON response will need to be updated if the schema changes. | ||
pub(crate) async fn mock_provider() -> Provider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key changes are:
WalletUnlocked
changes toWallet<Unlocked<S>>
Provider
is now required to unlock a wallet, so I added--node-url
as an option at the top level of the CLI so it can be set for any of the operations. Removed it from the subcommands.CliContext
containing the wallet_path and node_url since they have to get passed around in many placesderive_account_unlocked
that uses a mock ProviderCloses #226