Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: Update fuels and other dependencies #236

Merged
merged 7 commits into from
Mar 25, 2025
Merged

refac: Update fuels and other dependencies #236

merged 7 commits into from
Mar 25, 2025

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Mar 24, 2025

The key changes are:

  • WalletUnlocked changes to Wallet<Unlocked<S>>
  • Provider is now required to unlock a wallet, so I added --node-url as an option at the top level of the CLI so it can be set for any of the operations. Removed it from the subcommands.
  • Introduced CliContext containing the wallet_path and node_url since they have to get passed around in many places
  • Added a more thorough unit test of derive_account_unlocked that uses a mock Provider

Closes #226

@sdankel sdankel requested a review from a team March 25, 2025 00:06
@sdankel sdankel marked this pull request as ready for review March 25, 2025 00:23
kayagokalp
kayagokalp previously approved these changes Mar 25, 2025
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this one. I just left a question to understand whether bump was intended for this PR or not

Copy link

LCOV of commit 8bf1cb8 during CI #475

Summary coverage rate:
  lines......: 31.7% (395 of 1245 lines)
  functions..: 25.9% (50 of 193 functions)
  branches...: 79.2% (19 of 24 branches)

Files changed coverage rate: n/a

@sdankel sdankel requested a review from kayagokalp March 25, 2025 01:04
@sdankel sdankel merged commit 90a8cb2 into master Mar 25, 2025
12 checks passed
@sdankel sdankel deleted the sophie/up-deps branch March 25, 2025 01:56

/// Returns a mock provider with a mock fuel-core server that responds to the nodeInfo graphql query.
/// Note: the raw JSON response will need to be updated if the schema changes.
pub(crate) async fn mock_provider() -> Provider {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0421: idna accepts Punycode labels that do not produce any non-ASCII when decoded
4 participants