-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trait map to track fully resolved impl type parameters. #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0682aef
to
8746dab
Compare
CodSpeed Performance ReportMerging #6963 will not alter performanceComparing Summary
|
5546a8d
to
a7fba0d
Compare
a7fba0d
to
36468bc
Compare
36468bc
to
c56f8ed
Compare
c56f8ed
to
7ac8985
Compare
470bf26
to
c34499d
Compare
c34499d
to
bd6cb76
Compare
bd6cb76
to
629cc29
Compare
629cc29
to
0f84d12
Compare
This is now ready for a review, there were issues with LSP performance but they have been addressed with a different implementation for keeping track of type parameters. |
JoshuaBatty
previously approved these changes
Mar 5, 2025
IGI-111
previously approved these changes
Mar 7, 2025
IGI-111
approved these changes
Mar 7, 2025
JoshuaBatty
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler
General compiler. Should eventually become more specific as the issue is triaged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates trait map to track fully resolved impl type parameters.
To be used for trait coherence checking.
Checklist
Breaking*
orNew Feature
labels where relevant.