Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trait map to track fully resolved impl type parameters. #6963

Merged
merged 10 commits into from
Mar 9, 2025

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Feb 25, 2025

Description

Updates trait map to track fully resolved impl type parameters.

To be used for trait coherence checking.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Feb 25, 2025
@tritao tritao self-assigned this Feb 25, 2025
@tritao tritao requested a review from a team as a code owner February 25, 2025 21:09
@tritao tritao force-pushed the trait-map-trait-impls branch from 0682aef to 8746dab Compare February 25, 2025 21:13
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #6963 will not alter performance

Comparing tritao:trait-map-trait-impls (cc63a51) with master (27be22c)

Summary

✅ 22 untouched benchmarks

@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot March 3, 2025 05:44 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from 5546a8d to a7fba0d Compare March 3, 2025 12:38
@tritao tritao temporarily deployed to fuel-sway-bot March 3, 2025 12:39 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from a7fba0d to 36468bc Compare March 3, 2025 13:17
@tritao tritao temporarily deployed to fuel-sway-bot March 3, 2025 13:18 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from 36468bc to c56f8ed Compare March 3, 2025 13:32
@tritao tritao temporarily deployed to fuel-sway-bot March 3, 2025 13:34 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from c56f8ed to 7ac8985 Compare March 3, 2025 13:54
@tritao tritao temporarily deployed to fuel-sway-bot March 3, 2025 13:54 — with GitHub Actions Inactive
@tritao tritao temporarily deployed to fuel-sway-bot March 4, 2025 10:14 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from 470bf26 to c34499d Compare March 4, 2025 17:20
@tritao tritao temporarily deployed to fuel-sway-bot March 4, 2025 17:22 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from c34499d to bd6cb76 Compare March 4, 2025 17:51
@tritao tritao temporarily deployed to fuel-sway-bot March 4, 2025 17:52 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from bd6cb76 to 629cc29 Compare March 4, 2025 18:17
@tritao tritao temporarily deployed to fuel-sway-bot March 4, 2025 18:18 — with GitHub Actions Inactive
@tritao tritao force-pushed the trait-map-trait-impls branch from 629cc29 to 0f84d12 Compare March 4, 2025 19:01
@tritao tritao temporarily deployed to fuel-sway-bot March 4, 2025 19:02 — with GitHub Actions Inactive
@tritao
Copy link
Contributor Author

tritao commented Mar 5, 2025

This is now ready for a review, there were issues with LSP performance but they have been addressed with a different implementation for keeping track of type parameters.

JoshuaBatty
JoshuaBatty previously approved these changes Mar 5, 2025
@JoshuaBatty JoshuaBatty requested a review from a team March 5, 2025 22:17
IGI-111
IGI-111 previously approved these changes Mar 7, 2025
@tritao tritao dismissed stale reviews from IGI-111 and JoshuaBatty via a55211a March 7, 2025 11:31
@tritao tritao temporarily deployed to fuel-sway-bot March 7, 2025 11:33 — with GitHub Actions Inactive
@tritao tritao enabled auto-merge (squash) March 7, 2025 12:20
@tritao tritao requested review from JoshuaBatty and IGI-111 March 7, 2025 12:20
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot March 7, 2025 12:33 — with GitHub Actions Inactive
@tritao tritao merged commit 9739ec7 into FuelLabs:master Mar 9, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants