Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change blob ID calculation in forc-deploy to use configurables offset #6991

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Mar 5, 2025

Description

Closes #6990

The main change here is switching from using the data section offset to using the configurables offset in the blob loader in forc-deploy.

TODO: update the loader-abi.json test file(s) once deployment to testnet is working.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel temporarily deployed to fuel-sway-bot March 5, 2025 03:05 — with GitHub Actions Inactive
@sdankel sdankel changed the title chore: upgrade fuels-rs to 0.40.3 chore: upgrade fuels-rs to 0.70.3 Mar 5, 2025
@sdankel sdankel changed the title chore: upgrade fuels-rs to 0.70.3 chore: upgrade fuels-rs to 0.70.4 Mar 5, 2025
@sdankel sdankel temporarily deployed to fuel-sway-bot March 5, 2025 20:51 — with GitHub Actions Inactive
@sdankel sdankel temporarily deployed to fuel-sway-bot March 5, 2025 21:54 — with GitHub Actions Inactive
@sdankel sdankel requested a review from zees-dev March 5, 2025 21:59
@sdankel sdankel marked this pull request as ready for review March 5, 2025 21:59
@sdankel sdankel requested review from a team as code owners March 5, 2025 21:59
@sdankel sdankel changed the title chore: upgrade fuels-rs to 0.70.4 chore: Change blob ID calculation in forc-deploy to use configurables offset Mar 5, 2025
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we also bump the sdk version here or should do it separately?

@kayagokalp kayagokalp requested a review from a team March 5, 2025 23:14
@kayagokalp kayagokalp added the forc-deploy Everything to do with forc-deploy label Mar 5, 2025
@sdankel sdankel enabled auto-merge (squash) March 6, 2025 02:58
@sdankel
Copy link
Member Author

sdankel commented Mar 6, 2025

Thanks! Should we also bump the sdk version here or should do it separately?

It's bumped in Cargo.lock

@sdankel sdankel merged commit 8c0cc20 into master Mar 6, 2025
40 checks passed
@sdankel sdankel deleted the sophie/fuels-0.40.3 branch March 6, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forc-deploy Everything to do with forc-deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to fuels-rs 0.70.3
5 participants