Skip to content

Implement SDL3 - #7033

Merged
AbnormalPoof merged 1 commit into
dummy/develop-v0.8.3from
feature/sdl3-impl-da-master
Mar 10, 2026
Merged

Implement SDL3#7033
AbnormalPoof merged 1 commit into
dummy/develop-v0.8.3from
feature/sdl3-impl-da-master

Conversation

@MAJigsaw77

@MAJigsaw77 MAJigsaw77 commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

This pr implements one of biggest upgrades to our beloved library lime can have and that is implementing SDL3, in order for this to work, the following prs need to be merged:

The exact features that this upgrade implements are mostly inside the descriptions of each of the lib's pr, the features that are here in this pr's code are the following:

  • The input now uses nanoseconds instead of miliseconds which should make the already good input even better!
  • Adds vsync back on MacOS as SDL3 fixes the support for it.
  • Reimplements the previouly removed filters for FileDialogs on MacOS.
  • Adds the Unlocked Framerate option to native as the new mainloop can now support running uncapped.
  • Now the alert MessageBoxes with custom types work on all targets.
  • Applys the new Drop and FileDialogs API.
  • Fixes the resolution on iOS not being the native resolution.

@github-actions github-actions Bot added status: pending triage Awaiting review. size: huge A huge pull request with more than 500 changes. pr: haxe PR modifies game code. and removed size: huge A huge pull request with more than 500 changes. labels Feb 28, 2026
@ADA-Funni

ADA-Funni commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

I've noticed several performance increases and more precise input when playing the game with these changes.

Merge it!

KELOTOMU
KELOTOMU reviewed Mar 1, 2026
View reviewed changes

@KELOTOMU KELOTOMU left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good pr, but this will require lots of consideration and testing before this can be merged. PR also has some changes that are completely irrelevant on the implementation of SDL3, I suggest cleaning up first including the pr's for lime, openfl, flixel, and flixel-addons

@MAJigsaw77
MAJigsaw77 force-pushed the feature/sdl3-impl-da-master branch from 2d20c3c to 23d2039 Compare March 1, 2026 08:53
@github-actions github-actions Bot added the size: huge A huge pull request with more than 500 changes. label Mar 1, 2026
JVNpixels
JVNpixels approved these changes Mar 1, 2026
View reviewed changes

@JVNpixels JVNpixels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nanoseconds input

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: help wanted Ideal for work by outside contributors. labels Mar 1, 2026
@Hundrec Hundrec added this to the 0.8.4 milestone Mar 1, 2026
@Hundrec
Hundrec force-pushed the feature/sdl3-impl-da-master branch from 23d2039 to 5e96561 Compare March 1, 2026 09:26
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Mar 1, 2026
@Hundrec
Hundrec force-pushed the feature/sdl3-impl-da-master branch from 5e96561 to ddb7689 Compare March 1, 2026 11:24
@anysad

anysad commented Mar 1, 2026

Copy link
Copy Markdown
Contributor
image

@GabyStarStudiosOfficial

GabyStarStudiosOfficial commented Mar 1, 2026

Copy link
Copy Markdown

Pretty cool Jigsaw but...When making the stage and character assets...the image file format isn't separated
Screenshot 2026-03-01 143420

You screwed that up jigsaw!
GP4KEtMWsAAD9wF

@Hundrec Hundrec linked an issue Mar 1, 2026 that may be closed by this pull request
Bug Report: FPS in settings doesn't match cap set by user #4374
Closed
3 tasks
@realvirtu

realvirtu commented Mar 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

JIGSAW!! YEAH

@CEliuxJV

CEliuxJV commented Mar 1, 2026

Copy link
Copy Markdown

I remember downloading and playing Jigsaw's Android ports of Psych Engine because they were the best in my opinion. It's amazing to see how much he helps with the original game now
(Same with ZackDroid btw, but with his ports of the vanilla game, I think. ZackDroid also the goat).

556574029-593cebc3-692d-407d-bb6f-8ca3126596cb

@JackXson-Real

JackXson-Real commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

I think the issue with higher FPS affecting hold note scores should be fixed before merging this

@MAJigsaw77
MAJigsaw77 force-pushed the feature/sdl3-impl-da-master branch from ddb7689 to 69139c3 Compare March 1, 2026 18:32
@realvirtu

realvirtu commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

I think the issue with higher FPS affecting hold note scores should be fixed before merging this

Agree, but pretty sure there's a PR for that!

HomuHomu833 added a commit to ShadowEngineTeam/FNF-Shadow-Engine that referenced this pull request Mar 1, 2026
@HomuHomu833
add more shadows
a62c497 
mostly due to FunkinCrew/Funkin#7033, we'll not have SDL3 support.
Starexify
Starexify reviewed Mar 1, 2026
View reviewed changes

@Starexify Starexify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can finally play FNF with 8000 FPS

Image

@KaiCodesLol

KaiCodesLol commented Mar 1, 2026

Copy link
Copy Markdown

Make the input use picoseconds
for the bit

@Hundrec

Hundrec commented Mar 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Chart/stage loading and extension filters work after the latest push
image

@JVNpixels

JVNpixels commented Mar 1, 2026

Copy link
Copy Markdown
Contributor
image

@MAJigsaw77
MAJigsaw77 force-pushed the feature/sdl3-impl-da-master branch 2 times, most recently from 2725c47 to b56e18d Compare March 8, 2026 19:02
@Hundrec
Hundrec force-pushed the feature/sdl3-impl-da-master branch from b56e18d to f0cdd66 Compare March 9, 2026 09:05
@Hundrec Hundrec linked an issue Mar 9, 2026 that may be closed by this pull request
Bug Report: Scrolling on Menus (Excluding Freeplay) Occasionally Skips An Item #5606
Closed
3 tasks
@Hundrec
Hundrec changed the base branch from develop to dummy/develop-v0.8.3 March 10, 2026 08:40
@AbnormalPoof
AbnormalPoof force-pushed the feature/sdl3-impl-da-master branch 6 times, most recently from 7dcc847 to e31c969 Compare March 10, 2026 09:25
@AbnormalPoof
AbnormalPoof force-pushed the dummy/develop-v0.8.3 branch from 9a1a24d to ac31781 Compare March 10, 2026 09:39
@MAJigsaw77 @AbnormalPoof @KarimAkra
Implement SDL3
d5364e8 
Co-Authored-By: Abnormal <86753001+AbnormalPoof@users.noreply.github.com>
Co-Authored-By: Karim Akra <144803230+KarimAkra@users.noreply.github.com>
@AbnormalPoof
AbnormalPoof force-pushed the feature/sdl3-impl-da-master branch from e31c969 to d5364e8 Compare March 10, 2026 09:39
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. topic: help wanted Ideal for work by outside contributors. labels Mar 10, 2026
@AbnormalPoof
AbnormalPoof merged commit 519d669 into dummy/develop-v0.8.3 Mar 10, 2026
5 of 9 checks passed
Hundrec
Hundrec approved these changes Mar 10, 2026
View reviewed changes

@Hundrec Hundrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@fla-shu

fla-shu commented Mar 10, 2026

Copy link
Copy Markdown

MULTUMIM JIGSAW

@GabyStarStudiosOfficial

GabyStarStudiosOfficial commented Mar 10, 2026

Copy link
Copy Markdown

PRAISE JIGSAW!!

@AbnormalPoof
AbnormalPoof deleted the feature/sdl3-impl-da-master branch March 10, 2026 10:47
@Marcosayfi

Marcosayfi commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

YESSS

@Stoopid-Idiot

Stoopid-Idiot commented Mar 11, 2026

Copy link
Copy Markdown
image

HOORAY!

@Hundrec
Hundrec restored the feature/sdl3-impl-da-master branch March 15, 2026 00:03
@Hundrec Hundrec linked an issue Mar 15, 2026 that may be closed by this pull request
Bug Report: Controllers do not register triggers as valid inputs for notes #2346
Open
5 tasks
@Hundrec Hundrec removed a link to an issue Mar 15, 2026
Bug Report: Controllers do not register triggers as valid inputs for notes #2346
Open
5 tasks
@thatfurrykati

thatfurrykati commented Mar 26, 2026

Copy link
Copy Markdown

THANKS FOR THE CONTROLER SUPPORT I HAVE BEEN GRINDING ON THE DEV BUILD SO MUCH

@AbnormalPoof
AbnormalPoof deleted the feature/sdl3-impl-da-master branch March 31, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hundrec Hundrec Hundrec approved these changes
+5 more reviewers
@KELOTOMU KELOTOMU KELOTOMU left review comments
@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes
@Starexify Starexify Starexify approved these changes
@realvirtu realvirtu realvirtu approved these changes
@JVNpixels JVNpixels JVNpixels approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: huge A huge pull request with more than 500 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.

Milestone

0.8.4