Skip to content

[CRASHFIX] Fix crash with events on HashLink - #7103

Merged
AbnormalPoof merged 1 commit into
FunkinCrew:dummy/develop-v0.8.3from
NotHyper-474:fix/hl-event-crash
Mar 8, 2026
Merged

[CRASHFIX] Fix crash with events on HashLink#7103
AbnormalPoof merged 1 commit into
FunkinCrew:dummy/develop-v0.8.3from
NotHyper-474:fix/hl-event-crash

Conversation

@NotHyper-474

@NotHyper-474 NotHyper-474 commented Mar 8, 2026

Copy link
Copy Markdown
Collaborator

Description

This was a fix that I had already included in #6135, but that for some odd reason magically disappeared after being merged.
It makes the type of certain local variables explicit, since the code generator for HashLink will infer that the type for result should be the same as the return type, when it should be a Dynamic or Any instead.

@github-actions github-actions Bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. labels Mar 8, 2026
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Mar 8, 2026
@AbnormalPoof AbnormalPoof added this to the 0.8.4 milestone Mar 8, 2026
@AbnormalPoof
AbnormalPoof changed the base branch from develop to dummy/develop-v0.8.3 March 8, 2026 23:11
@AbnormalPoof

Copy link
Copy Markdown
Member

This is already fixed internally due to internal changes to song data but I'll merge this on public as well.

@AbnormalPoof
AbnormalPoof merged commit 9a669ad into FunkinCrew:dummy/develop-v0.8.3 Mar 8, 2026
6 checks passed
@NotHyper-474
NotHyper-474 deleted the fix/hl-event-crash branch March 8, 2026 23:13
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Mar 9, 2026
@Hundrec Hundrec added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression and removed type: minor bug Involves a minor bug or issue. labels Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Development

Successfully merging this pull request may close these issues.

3 participants