Minor prompt adjustments and docs #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
Related Documentation Checked 1 published document(s). No updates required. How did I do? Any feedback? |
jamesbraza
force-pushed
the
comments-json-change
branch
from
540f6e5 to
5fd2e7c
Compare
whitead
approved these changes
Sep 25, 2025
tests/test_paperqa.py
Outdated
Comment on lines
531
to
540
| settings.prompts.summary_json_system = ( | ||
| "Provide a summary of the excerpt that could help answer the question based on" | ||
| " the excerpt. The excerpt may be irrelevant. Do not directly answer the" | ||
| " question - only summarize relevant information. Respond with the following" | ||
| ' JSON format:\n\n {{\n"summary": "...",\n"author_name":' | ||
| ' "...",\n"relevance_score": "..."}}\n\n where `summary` is relevant' | ||
| " information from text - about 100 words words, `author_name` specifies the" | ||
| " author , and `relevance_score` is the relevance of `summary` to answer the" | ||
| " question (integer out of 10)." | ||
| "Provide a summary of the excerpt that could help answer the question" | ||
| " based on the excerpt. The excerpt may be irrelevant." | ||
| " Do not directly answer the question - only summarize relevant information." | ||
| " Respond with the following JSON format:" | ||
| '\n\n{{\n "summary": "...",\n "author_name": "...",\n "relevance_score": 1-10\n}}' | ||
| "\n\nwhere `summary` is relevant information from text - about 100 words words," | ||
| " `author_name` specifies the author," | ||
| " and `relevance_score` is an integer 1-10 for the relevance of `summary`" | ||
| " to the question." |
There was a problem hiding this comment.
This conflicts with prior - should be 0-10
There was a problem hiding this comment.
This prompt clobbers the prior and it doesn't mention the 0 score case. What I can do is just propagate the 0 score case here
There was a problem hiding this comment.
Alright it's done, agreed it's nice just to standardize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving my own PR comments