Skip to content

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Sep 26, 2025

This PR clears up some fuzziness in our evidence accounting:

  • Separating out current vs relevant evidence
  • Clarifying in gen_answer that it needs relevant evidence
  • Including the 'current question' for Best evidence message, to make it clear

@jamesbraza jamesbraza self-assigned this Sep 26, 2025
@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 20:20
@jamesbraza jamesbraza added the bug Something isn't working label Sep 26, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Sep 26, 2025
Copy link

dosubot bot commented Sep 26, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR clarifies the distinction between current evidence and relevant evidence in the system's evidence accounting, improving transparency in status reporting and tool descriptions.

  • Separates evidence counting into total evidence count vs relevant evidence count
  • Updates tool descriptions to clarify that gen_answer uses relevant evidence specifically
  • Enhances status messages to include the target question for better context

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/paperqa/agents/tools.py Updates status formatting, adds relevant evidence parameter, and clarifies gen_answer tool description
src/paperqa/agents/env.py Extends clinical trial status function with relevant evidence count parameter
tests/test_agents.py Updates test assertions to include the new relevant evidence count parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jamesbraza
Copy link
Collaborator Author

Closing in favor of #1113, let's just ditch irrelevant contexts instead of carting them around

@jamesbraza jamesbraza closed this Sep 27, 2025
@jamesbraza jamesbraza deleted the unifying-status branch September 27, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant