Skip to content

Showing scores over numbered list in gather_evidence best evidence #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Showing scores over numbered list in gather_evidence best evidence #1112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a0fae
Showing scores over numbered list in best evidence
jamesbraza Sep 26, 2025
dbd61a8
Having best evidence include 'current question', to make it clear
jamesbraza Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/paperqa/agents/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,16 +263,19 @@ async def gather_evidence(self, question: str, state: EnvironmentState) -> str:
reverse=True,
)

# Show scores over numbered list, since scores are actually the heuristic
top_contexts = "\n".join(
[
f"{n + 1}. {sc.context}\n"
for n, sc in enumerate(
sorted_relevant_contexts[: self.settings.agent.agent_evidence_n]
)
]
f"- Relevance score {sc.score}: {sc.context}\n"
for sc in sorted_relevant_contexts[: self.settings.agent.agent_evidence_n]
)

best_evidence = f" Best evidence(s):\n\n{top_contexts}" if top_contexts else ""
# Include 'current question' because different questions will lead to
# different best evidences being shown
best_evidence = (
f" Best evidence(s) current question:\n\n{top_contexts}"
Copy link
Collaborator Author

@jamesbraza jamesbraza Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f" Best evidence(s) current question:\n\n{top_contexts}"
f" Best evidence(s) for the current question:\n\n{top_contexts}"

if top_contexts
else ""
)

if f"{self.TOOL_FN_NAME}_completed" in self.settings.agent.callbacks:
await asyncio.gather(
Expand Down
Loading