Re-adding refurb
#1117
Merged
Re-adding refurb
#1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR re-adds the refurb linter to the CI workflow and applies several code improvements detected by refurb to enhance code quality and performance. The changes focus on simplifying code patterns and following Python best practices.
- Re-enables refurb linting in CI to catch code quality issues
- Simplifies list comprehensions and boolean checks
- Updates file handling to use modern Path methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/tests.yml | Adds refurb linting step to CI workflow |
| src/paperqa/utils.py | Adds noqa comment to suppress refurb warning |
| src/paperqa/clients/journal_quality.py | Updates file opening to use Path.open() method |
| src/paperqa/agents/tools.py | Simplifies list comprehension by removing unnecessary enumerate |
| tests/test_paperqa.py | Simplifies boolean assertion for bytes data |
| packages/paper-qa-pypdf/tests/test_paperqa_pypdf.py | Changes list to tuple and simplifies assertion |
| packages/paper-qa-pymupdf/tests/test_paperqa_pymupdf.py | Changes list to tuple and simplifies assertion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Related Documentation Checked 1 published document(s). No updates required. How did I do? Any feedback? |
jamesbraza
force-pushed
the
readding-refurb
branch
from
b3e26ac to
85f5ebf
Compare
whitead
approved these changes
Oct 3, 2025
dosubot
bot
added
size:M
|
Documentation Updates Checked 1 published document(s). No updates required. How did I do? Any feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized #1113 had left behind an extra
enumeratewe could have detected withrefurb