Pulled in latest tantivy for Document.from_dict typing fix
#916
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
jamesbraza
changed the title
tantivy for Document.from_dicttantivy for Document.from_dict typing fix
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tantivy dependency to version 0.22.2 to integrate the fix for the typing issue in Document.from_dict as described in the upstream PR. It synchronizes the version across both dependency files and removes the now-unnecessary type-ignore annotation in the search agent.
- Updated tantivy dependency and version pin in pyproject.toml.
- Adjusted .pre-commit-config.yaml to match the new tantivy version.
- Removed the type-ignore comment from the add_document call in paperqa/agents/search.py.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Pinned tantivy version to 0.22.2 for a typing fix in Document.from_dict. |
| .pre-commit-config.yaml | Updated tantivy version to match pyproject.toml. |
| paperqa/agents/search.py | Removed type-ignore comment in the call to Document.from_dict. |
Comments suppressed due to low confidence (1)
paperqa/agents/search.py:310
- Verify that the removal of the type ignore comment is safe with the updated tantivy version; ensure that Document.from_dict correctly accepts index_doc without type issues.
writer.add_document(Document.from_dict(index_doc))
maykcaldas
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in quickwit-oss/tantivy-py#346