Skip to content

Commit

Permalink
Fix Playwright versioning issue (#103)
Browse files Browse the repository at this point in the history
* Fix playwright pipeline

* Upgrade playwright to 1.45.0

* Add with-deps

* Add playwright envs

* Change installation order

* Do everything in src directory

* Set working-directory
  • Loading branch information
jescalada authored Jun 26, 2024
1 parent de21d6f commit 0a90752
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 21 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
branches: [ main, release/* ]
pull_request:
branches: [ main, release/* ]
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
PLAYWRIGHT_BROWSERS_PATH: 0

jobs:
test:
Expand All @@ -20,13 +23,17 @@ jobs:
node-version: 16

- name: Install frontend dependencies
run: cd src && npm ci --legacy-peer-deps
run: |
npx playwright install-deps
npm ci --legacy-peer-deps
working-directory: src

- name: Install wait-on
run: npm install -g wait-on

- name: Install Playwright browsers
run: npx playwright install --with-deps
run: npx playwright install
working-directory: src

- name: Build and run backend
run: |
Expand All @@ -49,10 +56,10 @@ jobs:
- name: Start frontend dev server and run E2E tests
run: |
cd src
npm start &
npx wait-on http://localhost:3000
npx playwright test src/e2e
working-directory: src

- name: Upload Playwright report
uses: actions/upload-artifact@v4
Expand Down
82 changes: 65 additions & 17 deletions src/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"memoize-one": "^5.2.1",
"moment": "^2.29.4",
"monaco-editor": "^0.33.0",
"playwright": "^1.44.1",
"playwright": "^1.45.0",
"plotly.js": "^2.7.0",
"prop-types": "^15.7.2",
"prosemirror-tables": "^1.1.1",
Expand Down

0 comments on commit 0a90752

Please sign in to comment.