Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images Explorer search and extras #108

Merged

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Jul 12, 2024

PR for G-Research/fasttrackml#1238. This PR enables searching images from the UI, including fetching the images from the backend with the new formatting. It also implements some of the missing functionalities that we added to Metrics/Params/Scatters over the months (Experiment Selector, Project Params Polling, etc.).

Please note that there's a bug with the images, clicking the Search button may not load the image URLs correctly (because the ImageBox components are not reloading). These will be fixed in G-Research/fasttrackml#1360.

Also, note that this PR depends on the following backend PR: G-Research/fasttrackml#1347.

Changelog

  • Add Image search on Images Explorer
    • Add formatting for URI so it can be used with local storage or with s3
    • Bug: When clicking search, the images themselves may not load, however they do load when refreshing the page
  • Add Experiment Selection Header to Images Explorer
  • Add polling for selection options

@jescalada jescalada self-assigned this Jul 12, 2024
@jescalada jescalada marked this pull request as draft July 12, 2024 16:20
@jescalada jescalada marked this pull request as ready for review July 26, 2024 17:21
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jescalada jescalada merged commit 9bf1c86 into G-Research:release/v3.17.5 Jul 31, 2024
3 of 4 checks passed
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
* Add experiment callbacks to app model

* Add images app

* Add experiment header

* Add formatted URI for artifact image fetching

* Add conditional formatting based on artifact_location

* Add project params polling for images

* Fix alignmentConfigs issue (temp)

* Replace GET with POST for images stream

* Remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aim Images: Aim Image Explorer Frontend Changes
2 participants