-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images Explorer search and extras #108
Merged
jescalada
merged 11 commits into
G-Research:release/v3.17.5
from
jescalada:v3.17.5-ImagesImplementation
Jul 31, 2024
Merged
Images Explorer search and extras #108
jescalada
merged 11 commits into
G-Research:release/v3.17.5
from
jescalada:v3.17.5-ImagesImplementation
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jescalada
commented
Jul 26, 2024
suprjinx
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Add experiment callbacks to app model * Add images app * Add experiment header * Add formatted URI for artifact image fetching * Add conditional formatting based on artifact_location * Add project params polling for images * Fix alignmentConfigs issue (temp) * Replace GET with POST for images stream * Remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for G-Research/fasttrackml#1238. This PR enables searching images from the UI, including fetching the images from the backend with the new formatting. It also implements some of the missing functionalities that we added to Metrics/Params/Scatters over the months (Experiment Selector, Project Params Polling, etc.).
Please note that there's a bug with the images, clicking the Search button may not load the image URLs correctly (because the
ImageBox
components are not reloading). These will be fixed in G-Research/fasttrackml#1360.Also, note that this PR depends on the following backend PR: G-Research/fasttrackml#1347.
Changelog