Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add Support for Power Usage Percentage and Watts #109

Merged

Conversation

vinayan3
Copy link

Add in the power wattage and percentage metrics because the MLFlow system monitor picks up on these metrics. The run details page will not render properly if these metrics are not put into the system metrics tab.

Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your first contribution @vinayan3!

I have just one tiny nitpick below but otherwise LGTM 👍

src/src/types/utils/formatSystemMetricName.d.ts Outdated Show resolved Hide resolved
@vinayan3 vinayan3 requested a review from jgiannuzzi July 30, 2024 17:34
@jgiannuzzi jgiannuzzi enabled auto-merge (squash) July 30, 2024 17:45
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@jgiannuzzi jgiannuzzi merged commit 201ffd2 into G-Research:release/v3.17.5 Jul 30, 2024
4 checks passed
vinayan3 added a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants