Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images UI Search fixes #111

Merged

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Aug 5, 2024

PR for G-Research/fasttrackml#1360

Changelog

  • Fix off by one issues related to index range
  • Fix images not loading/displaying when clicking Search
    • This fix involved removing one of the checks for the saved blobData, we want to refetch the blobData in case something changes between searches (indices, steps, etc.)

@jescalada jescalada self-assigned this Aug 5, 2024
@jescalada jescalada marked this pull request as ready for review August 5, 2024 21:09
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jescalada jescalada merged commit 3f4dc6e into G-Research:release/v3.17.5 Aug 6, 2024
4 checks passed
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
* Fix off by one bugs in index range

* Fix typos

* Fix image blob data not refreshing on Search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images UI doesn't load images correctly when clicking Search
2 participants