Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images Explorer testing and fixes #115

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Sep 3, 2024

This PR adds E2E tests for Images, as well as a small bugfix.

Note: Waiting for G-Research/fasttrackml#1409 to get merged to fix the pipeline. Tests can be executed locally by using the updated k6_load.js file from that PRs branch.

Changelog

  • Added E2E test suite for Images
    • Page can be navigated correctly
    • Images can be searched for
    • Caption is present when searching
    • Caption, name, index, etc. are present when hovering
    • Runs with images appear in the explorer table
    • Experiments can be navigated through the entries in the table
  • Fixed issue with project params not updating when changing selected experiments

@jescalada jescalada marked this pull request as ready for review September 4, 2024 10:04
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@jescalada jescalada merged commit 66edba6 into G-Research:release/v3.17.5 Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants