Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Selector in AIM UI #35

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Namespace Selector in AIM UI #35

merged 6 commits into from
Jan 18, 2024

Conversation

fabiovincenzi
Copy link
Collaborator

@fabiovincenzi fabiovincenzi commented Jan 12, 2024 •
edited
Loading

@fabiovincenzi fabiovincenzi mentioned this pull request Jan 14, 2024
Closed
2 tasks
@jgiannuzzi jgiannuzzi self-assigned this Jan 15, 2024
@jgiannuzzi jgiannuzzi added the enhancement New feature or request label Jan 15, 2024
@fabiovincenzi fabiovincenzi marked this pull request as ready for review January 15, 2024 16:40
@fabiovincenzi
Copy link
Collaborator Author

Screenshot 2024-01-15 at 18 19 09 Screenshot 2024-01-15 at 18 19 14

@dsuhinin
Copy link
Collaborator

dsuhinin commented Jan 16, 2024 •
edited
Loading

Ok, I have only one concern about that -> when we have long namespace name it looks a bit wired. so maybe, we don't need to show selected namespace name on the panel but instead just show namespace icon for example? then user can click on this icon and see selected namespace? what do you think?
cc: @jgiannuzzi
Screenshot 2024-01-16 at 17 54 57

Screenshot 2024-01-16 at 17 53 10

so I can't see example-1 and only case see exa... which is not really useful at all.

@fabiovincenzi
Copy link
Collaborator Author

I agree with the Icon! @dsuhinin
something like this:
Screenshot 2024-01-17 at 10 30 16
Screenshot 2024-01-17 at 10 30 37

@dsuhinin
Copy link
Collaborator

I agree with the Icon! @dsuhinin something like this: Screenshot 2024-01-17 at 10 30 16 Screenshot 2024-01-17 at 10 30 37

yes, this way looks better for me and reasonable.

dsuhinin
dsuhinin previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

@fabiovincenzi
Copy link
Collaborator Author

Now the tool tip shows the current namespace:
Screenshot 2024-01-18 at 10 25 53

@fabiovincenzi fabiovincenzi merged commit 0b38c7b into G-Research:release/v3.17.5 Jan 18, 2024
3 checks passed
vinayan3 pushed a commit to vinayan3/fasttrackml-ui-aim that referenced this pull request Aug 28, 2024
@fabiovincenzi @vinayan3
Namespace Selector in AIM UI (G-Research#35)
9f5460e 
Adds a new Namespace selector component on the AIM UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin approved these changes

Assignees

@fabiovincenzi fabiovincenzi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabiovincenzi @dsuhinin @jgiannuzzi