Preliminary ParamsScalePopover component #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Add ParamsScalePopover interfaces * Add preliminary ParamsScalePopover component * Add onParamsScaleTypeChange logic * Add ParamsScalePopover to Params Controls * Improve ParamsScalePopover logic * Load selected params into component * Store params scale type state * Unify props into single variable * Fix onParamsScaleTypeChange logic to handle selectedParams state * Add scale support for high plot charts * Add analytics * Remove todos * Fix popover styling bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a preliminary PR for G-Research/fasttrackml#67. I have added a new
ParamsScalePopovercomponent, which is similar to theAxesScalePopover, but should display a list of all the tracked params.Please let me know if there's anything that doesn't make sense or needs to be changed!
To do:
Fix styling issues with the popup trigger button not showing the appropriate active/hover stateChangelog:
ParamsScalePopovercomponent to the Params ControlsHighPlotchartonParamsScaleTypeChange()andselectedParamsto relevant classes