Disable Scaling for Point Params #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suprjinx
reviewed
Feb 1, 2024
suprjinx
previously approved these changes
Feb 1, 2024
suprjinx
reviewed
Feb 2, 2024
suprjinx
previously approved these changes
Feb 2, 2024
suprjinx
approved these changes
Feb 3, 2024
vinayan3
pushed a commit
to vinayan3/fasttrackml-ui-aim
that referenced
this pull request
Aug 28, 2024
* Add ParamsScalePopover interfaces * Add preliminary ParamsScalePopover component * Add onParamsScaleTypeChange logic * Add ParamsScalePopover to Params Controls * Improve ParamsScalePopover logic * Load selected params into component * Store params scale type state * Unify props into single variable * Fix onParamsScaleTypeChange logic to handle selectedParams state * Add scale support for high plot charts * Add analytics * Remove todos * Fix popover styling bug * Disable controls for Point params * Fix chart scale state not changing * Add tooltip overriding for ToggleButton * Fix ParamsScalePopover title/button styling issue * Add short comment for scale state functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for G-Research/fasttrackml#840.
Internally, this PR tries to centralize the scale state of the params, so that both the
ParamsScalePopoverand theHighPlotchart can use it. The main issue was that the scale states inselectedParamsare originally undefined, whereas theHighPlotneeds to be aware of the new states in order to render the axes for each param. I made a clear distinction between the two and made sure that theselectedParamsare appropriately updated from the beginning.I also solved some other styling issues by abridging long param names and allowing the tooltip to show the full name.
Changelog
ToggleButtonto see full param name onParamScalePopoverwhen it is too long