This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Applicant filtering api endpoint #5681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Classification Rule tests are not yet complete.
One case still failing
Codecov Report
@@ Coverage Diff @@
## dev #5681 +/- ##
============================================
- Coverage 50.66% 50.51% -0.14%
- Complexity 1803 1816 +13
============================================
Files 448 450 +2
Lines 10576 10626 +50
Branches 430 430
============================================
+ Hits 5357 5367 +10
- Misses 4903 4943 +40
Partials 316 316
|
mnigh
reviewed
Apr 14, 2021
| public function index(Request $request) | ||
| { | ||
| $expectsJson = $request->expectsJson(); | ||
| Log::debug("Expects json: $expectsJson"); |
There was a problem hiding this comment.
Is this leftover from testing?
mnigh
reviewed
Apr 14, 2021
| use App\Services\Validation\Rules\CommaSeparatedListRule; | ||
| use Illuminate\Database\Eloquent\Builder; | ||
| use App\Services\Validation\Rules\ValidClassificationRule; | ||
| use Illuminate\Support\Facades\Log; |
There was a problem hiding this comment.
Is this leftover from testing?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4966.
The endpoint is https://talent.test/api/v2/applicants, and filters are added via url queries. The endpoint currently accepts 4 queries:
An example query: https://talent.test/api/v2/applicants?classifications=CS-01,EX-ENG-02&skillIds=2,3,4&limit=50&offset=100
Notes: