Skip to content

fix(KafkaClientExtensions): Fix uppercase characters not being allowed in CloudEvents #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GermanCoding wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(KafkaClientExtensions): Fix uppercase characters not being allowed in CloudEvents #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Motor.Extensions.Hosting.Kafka/KafkaClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ MotorCloudEvent<byte[]> motorCloudEvent
{
try
{
motorCloudEvent.SetAttributeFromString(header.Key, Encoding.UTF8.GetString(headerValue));
motorCloudEvent.SetAttributeFromString(
header.Key.ToLowerInvariant(),
Encoding.UTF8.GetString(headerValue)
);
}
catch (ArgumentException)
{
Expand Down
7 changes: 4 additions & 3 deletions test/Motor.Extensions.Hosting.Kafka_IntegrationTest/KafkaExtensionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,20 @@ public async Task Consume_RawPublishIntoKafkaAndConsumeCreateCloudEvent_Consumed
public async Task Consume_RawPublishWithKafkaHeader_HeaderValueIsAvailableAsCloudEventAttribute()
{
var topic = NewTopic();
const string headerKey = "customheader";
const string headerKeyOriginal = "CustomHeaderNamE";
const string headerKeyConverted = "customheadername";
const string headerValue = "customHeaderValue";
await PublishMessage(
topic,
"someKey",
Message,
new Headers { { headerKey, Encoding.UTF8.GetBytes(headerValue) } }
new Headers { { headerKeyOriginal, Encoding.UTF8.GetBytes(headerValue) } }
);
using var consumer = GetConsumer<string>(topic);
var consumedHeaderValueCompletionSource = new TaskCompletionSource<string?>();
consumer.ConsumeCallbackAsync = (dataEvent, _) =>
{
consumedHeaderValueCompletionSource.TrySetResult(dataEvent[headerKey] as string);
consumedHeaderValueCompletionSource.TrySetResult(dataEvent[headerKeyConverted] as string);
return Task.FromResult(ProcessedMessageStatus.Success);
};

Expand Down
2 changes: 1 addition & 1 deletion test/Motor.Extensions.Hosting.Kafka_UnitTest/KafkaMessageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void KafkaMessageToCloudEvent_WithHeaders_HeadersExtractedToCloudEvent()
var kafkaMessage = publisher.CloudEventToKafkaMessage(inputCloudEvent);
kafkaMessage.Headers ??= new Headers();
kafkaMessage.Headers.Add("firstcustomheader", "customvalue"u8.ToArray());
kafkaMessage.Headers.Add("secondcustomheader", "customvalue_two"u8.ToArray());
kafkaMessage.Headers.Add("SECONDCUSTOMHEADER", "customvalue_two"u8.ToArray());

var outputCloudEvent = consumer.KafkaMessageToCloudEvent(kafkaMessage);

Expand Down
Loading