Skip to content

Chore: local profile env 변수 적용 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CSE-Shaco merged 1 commit into from
Jan 8, 2026
Merged

Chore: local profile env 변수 적용 #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/resources/application-local.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ spring:
jackson:
time-zone: Asia/Seoul
datasource:
url: "jdbc:postgresql://localhost:5432/gdgoc"
username: "postgres"
password:
url: ${DB_URL}
username: ${DB_USERNAME}
password: ${DB_PASSWORD}
Comment on lines +13 to +15
Copy link

@coderabbitai coderabbitai bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Comprehensive verification of the review comment claims

echo "=== 1. Checking application-local.yml file structure (lines 1-30) ==="
if [ -f src/main/resources/application-local.yml ]; then
  cat -n src/main/resources/application-local.yml | head -30
else
  echo "File not found at src/main/resources/application-local.yml"
fi

echo -e "\n=== 2. Checking lines around 13-15 for datasource config ==="
if [ -f src/main/resources/application-local.yml ]; then
  cat -n src/main/resources/application-local.yml | sed -n '10,20p'
fi

echo -e "\n=== 3. Checking for .gitignore and .env entries ==="
if [ -f .gitignore ]; then
  echo "=== .gitignore contents ==="
  cat -n .gitignore | head -50
else
  echo ".gitignore not found"
fi

echo -e "\n=== 4. Checking for .env.example or similar files ==="
fd -t f '\.(env|config)' . --max-depth 2 2>/dev/null | grep -E '\.(env|example|sample|template)'

echo -e "\n=== 5. Checking README for environment configuration documentation ==="
fd -t f 'README*' . --max-depth 2 -x cat -n {} \; 2>/dev/null | head -100

echo -e "\n=== 6. Checking for typo at line 68 mentioned in review ==="
if [ -f src/main/resources/application-local.yml ]; then
  wc -l src/main/resources/application-local.yml
  cat -n src/main/resources/application-local.yml | sed -n '65,71p'
fi

Repository: GDGoCINHA/24-2_GDGoC_Server

Length of output: 2593

🏁 Script executed:

#!/bin/bash
# Additional verification for README and .env.example

echo "=== Checking for README files in repository ==="
fd -t f 'README' . 2>/dev/null

echo -e "\n=== Checking root directory structure ==="
ls -la | head -20

echo -e "\n=== Checking if .env or .env.example exist ==="
ls -la | grep -E '\.env|\.properties'

echo -e "\n=== Verifying environment variable usage pattern elsewhere in file ==="
grep -n '\${[A-Z_]*}' src/main/resources/application-local.yml | head -15

Repository: GDGoCINHA/24-2_GDGoC_Server

Length of output: 1990

환경 변수로의 전환이 올바르게 적용되었습니다.

데이터베이스 연결 정보를 환경 변수로 변경한 것은 보안 관점에서 좋은 개선입니다. 다른 민감한 정보(GMAIL, AWS 키, Google OAuth 등)와 일관된 패턴을 따르고 있습니다.

다음 사항들을 해결해 주세요:

  • .env.example 파일이 누락되었습니다. .gitignore에서 이 파일을 추적하고 있으므로, 개발자들의 로컬 환경 설정을 위해 DB_URL, DB_USERNAME, DB_PASSWORD 등의 필수 환경 변수를 명시한 .env.example 파일을 작성해야 합니다.
  • 환경 변수 설정 방법을 문서화하는 README 파일이 필요합니다. 이 파일에는 .env.example을 기반으로 로컬 환경을 설정하는 방법을 설명해야 합니다.

추가로, 라인 68의 org.hibername.type은 org.hibernate.type으로 수정되어야 합니다.

🤖 Prompt for AI Agents 
In @src/main/resources/application-local.yml around lines 13 - 15, Add a
.env.example file listing the required env vars (DB_URL, DB_USERNAME,
DB_PASSWORD and other sensitive keys like GMAIL, AWS keys, GOOGLE_OAUTH) so
developers can copy it for local setup; update the README to document how to
populate .env from .env.example and how to export/load these variables for local
runs; and fix the typo in the configuration key by replacing org.hibername.type
with the correct org.hibernate.type in the config where it appears.

servlet:
multipart:
max-file-size: 10MB
Expand Down
Loading