building hA2025 model #459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusense
reviewed
Aug 29, 2025
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This seems to be a private, specific script and I question it's general use and thus the addition to the repo
| @@ -0,0 +1,1631 @@ | |||
| //____________________________________________________________________________ | |||
| /* | |||
| Copyright (c) 2003-2024, The GENIE Collaboration | |||
There was a problem hiding this comment.
Copyrights everywhere should be brought up-to-date to include 2025
| For the full text of the license visit http://copyright.genie-mc.org | ||
|
|
||
|
|
||
| Author: Steve Dytman <[email protected]>, Pittsburgh Univ. |
There was a problem hiding this comment.
Is this author list accurate? The date at the end suggests that this is a from a copy of another file.
|
|
||
| For the class documentation see the corresponding header file. | ||
|
|
||
| Important revisions after version 2.0.0 : |
There was a problem hiding this comment.
Are these revision comments accurate for this file?
I suspect that the boilerplate comments for all the files in this PR need to be reviewed for relevancy and completeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a new class for hA2025 with the corresponding cross section data