Skip to content

v12: Handmerge main into v12 - 2026-Mar-23#190

Open
mathomp4 wants to merge 20 commits intofeature/sdrabenh/gcm_v12from
merge/handmerge/main-into-v12-2026Mar23-util
Open

v12: Handmerge main into v12 - 2026-Mar-23#190
mathomp4 wants to merge 20 commits intofeature/sdrabenh/gcm_v12from
merge/handmerge/main-into-v12-2026Mar23-util

Conversation

@mathomp4
Copy link
Member

Supersedes #182

This is a handmerge of main into feature/sdrabenh/gcm_v12. This mainly gets in some PRs that have recently been in main:

Now, the main reason I didn't just push this was because of #188 which fixed the WEMIN bits.

I think this is fine but I want @biljanaorescanin, @weiyuan-jiang and @gmao-rreichle to say "Yes, even v12 needs this" before I merge in.

@mathomp4 mathomp4 requested a review from a team as a code owner March 23, 2026 19:39
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 23, 2026
@mathomp4 mathomp4 requested a review from a team as a code owner March 23, 2026 19:39
@gmao-rreichle
Copy link
Contributor

I think this is fine but I want @biljanaorescanin, @weiyuan-jiang and @gmao-rreichle to say "Yes, even v12 needs this" before I merge in.

@mathomp4 : Based on a very quick inspection, the source code changes look ok to me. It would be good for @biljanaorescanin and @weiyuan-jiang to double-check.
I don't know how much effort we want to put into CHANGELOG.md. I think we missed a CHANGELOG.md entry for #188 in the original PR, and it's consequently missing here. If you're ok with it, so am I.

@weiyuan-jiang
Copy link
Contributor

Supersedes #182

This is a handmerge of main into feature/sdrabenh/gcm_v12. This mainly gets in some PRs that have recently been in main:

Now, the main reason I didn't just push this was because of #188 which fixed the WEMIN bits.

I think this is fine but I want @biljanaorescanin, @weiyuan-jiang and @gmao-rreichle to say "Yes, even v12 needs thieven v12 needs thiss" before I merge in.

Yes,

Supersedes #182

This is a handmerge of main into feature/sdrabenh/gcm_v12. This mainly gets in some PRs that have recently been in main:

Now, the main reason I didn't just push this was because of #188 which fixed the WEMIN bits.

I think this is fine but I want @biljanaorescanin, @weiyuan-jiang and @gmao-rreichle to say "Yes, even v12 needs this" before I merge in.

Yes, we need this fix. But this "bug" will not show up in this remap_package if the users go through the normal process

…o-v12-2026Mar23-util

# Conflicts:
#	CHANGELOG.md
@mathomp4
Copy link
Member Author

Okay @weiyuan-jiang @gmao-rreichle @biljanaorescanin

Can you look at this again. We merged in #179 and #181 into v12, and then I updated this branch here with those changes. It should be the same changes as before, but I want to be sure it looks good to your eyes.

@biljanaorescanin
Copy link
Contributor

Looks good to me as well.

Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants