Skip to content

Commit QC changes for satwinds again #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtodling merged 3 commits into from
Feb 2, 2026
Merged

Commit QC changes for satwinds again #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3798f14
commit changes for satwinds again
gmao-yzhu Jan 31, 2026
7c70a85
Merge branch 'develop' into feature/sat_winds_zhu
rtodling Feb 2, 2026
253940e
add for consistency w/ forward gsi
rtodling Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions GEOSaana_GridComp/GSI_GridComp/etc/gmao_global_convinfo.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@
uv 243 57 1 3.0 0 0 0 1.5 15.0 1.4 1.5 0.055000 1 200. 100. 0 0. 0.
uv 243 70 1 3.0 0 0 0 1.5 15.0 1.4 1.5 0.055000 1 200. 100. 0 0. 0.
uv 244 0 -1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 3 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 4 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 3 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 200. 100. 0 0. 0.
uv 244 4 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 200. 100. 0 0. 0.
uv 244 5 -1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 206 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 207 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 209 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 223 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 244 209 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 125. 0. 0 0. 0.
uv 244 223 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 125. 0. 0 0. 0.
uv 245 0 -1 3.0 0 0 0 2.5 20.0 1.4 1.3 0.005000 1 200. 100. 0 0. 0.
uv 245 252 -1 3.0 0 0 0 2.5 20.0 1.4 1.3 0.005000 1 200. 100. 0 0. 0.
uv 245 253 -1 3.0 0 0 0 2.5 20.0 1.4 1.3 0.005000 1 200. 100. 0 0. 0.
Expand Down Expand Up @@ -175,8 +175,8 @@
uv 247 256 -1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 257 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 259 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 270 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 271 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 270 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 200. 100. 0 0. 0.
uv 247 271 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 1 200. 100. 0 0. 0.
uv 247 272 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 247 273 1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.005000 0 0. 0. 0 0. 0.
uv 248 0 -1 3.0 0 0 0 2.5 20.0 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
Expand Down Expand Up @@ -218,30 +218,30 @@
uv 255 854 -1 3.0 0 0 0 1.5 20.0 1.4 1.5 0.050500 1 200. 100. 0 0. 0.
uv 256 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 257 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 257 783 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 257 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 257 783 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 1 75. 50. 0 0. 0.
uv 257 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 1 100. 50. 0 0. 0.
uv 258 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 258 783 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 258 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 258 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 1 125. 0. 0 0. 0.
uv 259 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 259 783 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 259 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 0 0. 0. 0 0. 0.
uv 259 784 1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.005500 1 100. 0. 0 0. 0.
uv 260 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 260 224 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 260 225 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 260 226 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 270 0 -1 3.0 0 0 0 2.5 20.1 1.4 2.5 0.000500 0 0. 0. 0 0. 0.
uv 275 0 -1 3.0 0 0 0 8.0 6.1 1.4 8.0 0.000001 0 0. 0. 0 0. 0.
uv 280 0 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 280 1 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 280 0 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 1 50. 0. 0 0. 0.
uv 280 1 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 1 50. 0. 0 0. 0.
uv 281 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 282 0 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 284 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 285 0 1 3.0 0 0 0 1.4 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
uv 286 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 287 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.000500 0 0. 0. 0 0. 0.
uv 289 0 1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 0 0. 0. 0 0. 0.
uv 290 4 -1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
uv 290 4 -1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 150. 1200. 0 0. 0.
uv 290 3 1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
uv 290 5 -1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
uv 291 0 1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
Expand Down
2 changes: 1 addition & 1 deletion GEOSaana_GridComp/GSI_GridComp/etc/gsi.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
/
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.true.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
Expand Down
2 changes: 1 addition & 1 deletion GEOSaana_GridComp/GSI_GridComp/etc/gsi_sens.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
/
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.true.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
Expand Down
23 changes: 18 additions & 5 deletions GEOSaana_GridComp/GSI_GridComp/read_satwnd.f90
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@jemccurr jemccurr Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the 'hamd' variable isn't being used besides being set to -1. Should it still be in the file?

Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
! or hilber curve downweighting
! 2021-06-21 Todling - Allow code to bypass hack to half-GOES-R errors
! 2020-05-04 wu - no rotate_wind for fv3_regional
! 2021-07-25 Genkova - added code for Metop-B/C winds in new BUFR,NC005081 !
! 2022-01-20 Genkova - added missing station_id for polar winds
! 2022-01-20 Genkova - added code for Meteosat and Himawari AMVs in new BUFR
! 2021-07-25 Genkova - added code for Metop-B/C winds in new BUFR,NC005081 !
! 2021-11-15 Eunhee - add QC for MSG IR winds and modified QC for IR winds over land and top air winds removal
! 2022-01-20 Genkova - added missing station_id for polar winds
! 2022-01-20 Genkova - added code for Meteosat and Himawari AMVs in new BUFR
!
!
! input argument list:
Expand Down Expand Up @@ -144,6 +145,7 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
real(r_kind),parameter:: r105= 105.0_r_kind
real(r_kind),parameter:: r110= 110.0_r_kind
real(r_kind),parameter:: r125=125.0_r_kind
real(r_kind),parameter:: r150=150.0_r_kind
real(r_kind),parameter:: r200=200.0_r_kind
real(r_kind),parameter:: r250=250.0_r_kind
real(r_kind),parameter:: r360 = 360.0_r_kind
Expand Down Expand Up @@ -179,7 +181,7 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
integer(i_kind) nmind,lunin,idate,ilat,ilon,iret,k
integer(i_kind) nreal,ithin,iout,ntmp,icount,iiout,ii
integer(i_kind) itype,iosub,ixsub,isubsub,iobsub,itypey,ierr
integer(i_kind) qm
integer(i_kind) qm, hamd
integer(i_kind) nlevp ! vertical level for thinning
integer(i_kind) pflag
integer(i_kind) ntest,nvtest
Expand Down Expand Up @@ -637,6 +639,7 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
ee=r110
qifn=r110
qify=r110
hamd=-1

! Test for BUFR version using lat/lon mnemonics
call ufbint(lunin,hdrdat_test,2,1,iret, 'CLAT CLON')
Expand All @@ -653,7 +656,8 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
hdrdat(3) >100000000.0_r_kind .or. &
obsdat(4) > 100000000.0_r_kind) cycle loop_readsb
if(ppb >r10000) ppb=ppb/r100
if (ppb <r125) cycle loop_readsb ! reject data above 125mb
! if (ppb <r125) cycle loop_readsb ! reject data above 125mb
if (ppb <r150) cycle loop_readsb ! reject data above 150mb based on monitoring
if(hdrdat(13) == 12.0_r_kind .or. hdrdat(13) == 14.0_r_kind) cycle loop_readsb
if (twodvar_regional .and. ppb <r850) cycle loop_readsb
! reject the data with bad quality mark from SDM
Expand Down Expand Up @@ -1285,6 +1289,15 @@ subroutine read_satwnd(nread,ndata,nodata,infile,obstype,lunout,gstime,twind,sis
if(hdrdat(2) >20.0_r_kind) then
call deter_sfc_type(dlat_earth,dlon_earth,t4dv,isflg,tsavg)
if(isflg /= 0) cycle loop_readsb
else
call deter_sfc_type(dlat_earth,dlon_earth,t4dv,isflg,tsavg)
if (isflg /= 0 .and. ppb > 700.0_r_kind) cycle loop_readsb ! low over land
endif
endif
if(itype ==253) then
if(hdrdat(2) >5.0_r_kind) then
call deter_sfc_type(dlat_earth,dlon_earth,t4dv,isflg,tsavg)
if(isflg /= 0 ) cycle loop_readsb
endif
endif
endif
Expand Down
29 changes: 15 additions & 14 deletions GEOSaana_GridComp/GSI_GridComp/setupw.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ subroutine setupw(obsLL,odiagLL,lunin,mype,bwork,awork,nele,nobs,is,conv_diagsav
! 2018-04-09 pondeca - introduce duplogic to correctly handle the characterization of
! duplicate obs in twodvar_regional applications
! 2020-02-26 todling - reset obsbin from hr to min
! 2021-11-15 Eunhee - Remove the QC for ir winds in the mid atmospheric layer if qc_satwnds=true
!
!
! REMARKS:
Expand Down Expand Up @@ -1054,20 +1055,20 @@ subroutine setupw(obsLL,odiagLL,lunin,mype,bwork,awork,nele,nobs,is,conv_diagsav
if(itype ==242 .or. itype ==243 ) then ! visible winds from JMA and EUMETSAT
if(presw <700.0_r_kind) error=zero ! no visible winds above 700mb
endif
if(itype ==245 ) then
if( presw >399.0_r_kind .and. presw <801.0_r_kind) then !GOES IR winds
error=zero ! no data between 400-800mb
endif
endif
if(itype == 252 .and. presw >499.0_r_kind .and. presw <801.0_r_kind) then ! JMA IR winds
error=zero
endif
if(itype == 253 ) then
if(presw >401.0_r_kind .and. presw <801.0_r_kind) then ! EUMET IR winds
error=zero
endif
endif
if( itype == 246 .or. itype == 250 .or. itype == 254 ) then ! water vapor cloud top
! if(itype ==245 ) then
! if( presw >399.0_r_kind .and. presw <801.0_r_kind) then !GOES IR winds
! error=zero ! no data between 400-800mb
! endif
! endif
! if(itype == 252 .and. presw >499.0_r_kind .and. presw <801.0_r_kind) then ! JMA IR winds
! error=zero
! endif
! if(itype == 253 ) then
! if(presw >401.0_r_kind .and. presw <801.0_r_kind) then ! EUMET IR winds
! error=zero
! endif
! endif
if( itype == 246 .or. itype == 247 .or. itype == 250 .or. itype == 254 ) then ! water vapor cloud top
if(presw >399.0_r_kind) error=zero
endif
if(itype ==257 .and. presw <249.0_r_kind) error=zero
Expand Down
Loading