Skip to content

Add extra ABI output and change water vapor unit #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtodling merged 4 commits into from
Feb 11, 2026
Merged

Add extra ABI output and change water vapor unit #227

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9553cc
Add extra ABI output and change water vapor unit
mhan-mars Feb 3, 2026
737fa55
merge w/ dev
rtodling Feb 11, 2026
4facadf
safer logic
rtodling Feb 11, 2026
9774774
explain
rtodling Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion GEOSaana_GridComp/GSI_GridComp/setuprad.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2664,6 +2664,9 @@ subroutine contents_netcdf_diag_(odiags,idv,iob)
call nc_diag_metadata("SST_Cool_layer_tdrop", sngl(data_s(idtc,n)) ) ! dt_cool at zob
call nc_diag_metadata("SST_dTz_dTfound", sngl(data_s(itz_tr,n)) ) ! d(Tz)/d(Tr)

if (abi) then
call nc_diag_metadata("standard_deviation_clear_bt", sngl(tb_obs_sdv(ich_diag(i))) ) ! tb_obs_sdv (K)
endif
call nc_diag_metadata("Observation", sngl(tb_obs(ich_diag(i))) ) ! observed brightness temperature (K)
call nc_diag_metadata("Obs_Minus_Forecast_adjusted", sngl(tbc0(ich_diag(i) )) ) ! observed - simulated Tb with bias corrrection (K)
call nc_diag_metadata("Obs_Minus_Forecast_unadjusted", sngl(tbcnob(ich_diag(i))) ) ! observed - simulated Tb with no bias correction (K)
Expand Down Expand Up @@ -2775,7 +2778,11 @@ subroutine contents_netcdf_diag_(odiags,idv,iob)

do iabsorb = 1, n_absorbers
write (fieldname, "(A,I0.2)") "atmosphere_absorber_", atmosphere(1)%absorber_id(iabsorb)
call nc_diag_data2d(trim(fieldname), sngl(atmosphere(1)%absorber(:,iabsorb))) ! check %absorber_units
if (iabsorb == 1) then
Copy link
Copy Markdown
Contributor

@rtodling rtodling Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this scaling or not scaling option? Is something wrong w/ the way the code scales the quantity of interest here?

I'll also add that this change is bit dangerous since it implies the order of aborbers is what you think it is ...

call nc_diag_data2d(trim(fieldname), sngl(atmosphere(1)%absorber(:,iabsorb)/1000.0)) ! check %absorber_units
else
call nc_diag_data2d(trim(fieldname), sngl(atmosphere(1)%absorber(:,iabsorb))) ! check %absorber_units
endif
enddo
do icloud = 1, n_clouds_fwd_wk
write (fieldname, "(A,I0.2)") "atmosphere_mass_content_of_cloud_", atmosphere(1)%Cloud(icloud)%Type
Expand Down
Loading