Skip to content

Fix module_mp_radar USE dependency invisible to CMake scanner #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mathomp4 wants to merge 3 commits into
base: feature/dbarahon/rc23_MG3
Choose a base branch
from
Draft

Fix module_mp_radar USE dependency invisible to CMake scanner #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e9877c
Fix module_mp_radar USE dependency invisible to CMake scanner
mathomp4 Mar 6, 2026
89ebed6
Fix not() on logical should be .not. operator
mathomp4 Mar 7, 2026
d0b61d8
Fix CHARACTER length mismatch in SHORT_NAME array constructor
mathomp4 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GEOSagcm_GridComp/GEOSphysics_GridComp/GEOS_PhysicsGridComp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1886,7 +1886,7 @@ subroutine SetServices ( GC, RC )
VERIFY_(STATUS)

call MAPL_AddConnectivity ( GC, &
SHORT_NAME = (/'ALH', 'KM', 'RI'/), &
SHORT_NAME = (/'ALH', 'KM ', 'RI '/), &
DST_ID = MOIST, &
SRC_ID = TURBL, &
RC=STATUS )
Expand Down
2 changes: 1 addition & 1 deletion GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/GEOS_MoistGridComp.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5949,7 +5949,7 @@ subroutine RUN ( GC, IMPORT, EXPORT, CLOCK, RC )
call MAPL_TimerOn (MAPL,"---AERO_ACTIVATE")


if ((USE_AEROSOL_NN) .and. not (USE_NCLOUD_CLIM)) then
if ((USE_AEROSOL_NN) .and. .not. (USE_NCLOUD_CLIM)) then
! get veritical velocity
if (all(W == 0.0)) then
TMP3D = -OMEGA/(MAPL_GRAV*PLmb*100.0/(MAPL_RGAS*T))
Expand Down
5 changes: 1 addition & 4 deletions GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSmoist_GridComp/Process_Library.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module GEOSmoist_Process_Library
use ESMF
use MAPL
use GEOS_UtilsMod
use module_mp_radar
!use Aer_Actv_Single_Moment
!use aer_cloud

Expand Down Expand Up @@ -4061,8 +4062,6 @@ END FUNCTION GAMMLN

subroutine init_refl10cm ()

USE module_mp_radar

IMPLICIT NONE

integer :: n
Expand Down Expand Up @@ -4196,8 +4195,6 @@ subroutine calc_refl10cm (qv1d, qr1d, nr1d, qs1d, qg1d, &
t1d, p1d, dBZ, rand1, kts, kte, ii, jj, &
vt_dBZ, first_time_step, ktopin, kbotin)

USE module_mp_radar

IMPLICIT NONE

!..Sub arguments
Expand Down