cleanup of scaling albedo with fpar#589
Merged
gmao-rreichle merged 2 commits intorreichle/cleanup/make_bcsfrom May 23, 2022
Merged
cleanup of scaling albedo with fpar#589gmao-rreichle merged 2 commits intorreichle/cleanup/make_bcsfrom
gmao-rreichle merged 2 commits intorreichle/cleanup/make_bcsfrom
Conversation
Contributor
|
Thanks, @biljanaorescanin, for putting this together. I don't have time to look at the changes in detail until later this week or next. |
…betacf(), gammaln()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing model/ experiment specific scaling with fpar. This option was by default set to zero, scaling was not used, this cleanup is zero diff. In boundary conditions package, option to create these parameters was commented out as well, so change is zero diff for boundary conditions as well.
@gmao-rreichle @gmao-jkolassa @rdkoster