Skip to content

Add river routing#850

Open
gmao-rreichle wants to merge 12 commits intodevelopfrom
feature/rreichle/route
Open

Add river routing#850
gmao-rreichle wants to merge 12 commits intodevelopfrom
feature/rreichle/route

Conversation

@gmao-rreichle
Copy link
Copy Markdown
Contributor

@gmao-rreichle gmao-rreichle commented Dec 3, 2025

Related PRs:
GEOS-ESM/GEOSldas_GridComp#145
GEOS-ESM/GEOSgcm_GridComp#1143
GEOS-ESM/MAPL#4000 (merged and captured in MAPL v2.64.0)

Comment thread doc/README.OutputSpecs.md Outdated
@biljanaorescanin
Copy link
Copy Markdown
Contributor

biljanaorescanin commented Apr 10, 2026

@zyj8881357 conflict on PR is still not resolved. Are we using new MAPL or not?

@gmao-rreichle
Copy link
Copy Markdown
Contributor Author

@zyj8881357 conflict on PR is still not resolved. Are we using new MAPL or not?

I merged develop, which fixes this. See also #857

@biljanaorescanin
Copy link
Copy Markdown
Contributor

All tests passed.

Interesting tidbit:
Initially, the globalcs test failed. It turned out I was running tests on discover31, but this test requires running the package on discover36. Since for that test we need MERRA2 meteorological forcing, which leads to a segmentation fault for this case.

@biljanaorescanin biljanaorescanin marked this pull request as ready for review April 10, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-diff enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants