Skip to content

Auto PR - develop → MAPL-v3 - fix bug in ASCAT_EUMET soil moisture obs reader #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathomp4 merged 3 commits into from
Nov 17, 2025
Merged

Auto PR - develop → MAPL-v3 - fix bug in ASCAT_EUMET soil moisture obs reader #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2554b85
fix bug in ASCAT_EUMET soil moisture obs reader
gmao-rreichle Nov 14, 2025
4f0396a
updated CHANGELOG.md
gmao-rreichle Nov 14, 2025
4bce232
fix bug in ASCAT_EUMET soil moisture obs reader #148
gmao-rreichle Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed bug in ASCAT EUMET soil moisture obs reader.
- Fixed Restart=1 when the domain is not global.

### Removed
Expand Down
4 changes: 2 additions & 2 deletions GEOSlandassim_GridComp/clsm_ensupd_read_obs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,8 +1951,8 @@ subroutine read_obs_sm_ASCAT_EUMET( &
date_time_tmp%sec = int(tmp_data(kk, 6))

! skip if record outside of current assim window
if ( datetime_lt_refdatetime( date_time_tmp, date_time_low ) .and. &
datetime_le_refdatetime( date_time_up, date_time_tmp ) ) cycle
if ( datetime_lt_refdatetime( date_time_tmp, date_time_low ) .or. & ! obs is before start of assim window *or*
datetime_le_refdatetime( date_time_up, date_time_tmp ) ) cycle ! obs is after end of assim window

! skip if record contains invalid soil moisture value
if ( tmp_data(kk, 7) > 100. .or. tmp_data(kk, 7) < 0. ) cycle
Expand Down