Add overloads to fix precision issues with g_sum#95
Closed
mathomp4 wants to merge 1 commit intofeature/sdrabenh/fix_fvdycore_layout_regressfrom
Closed
Add overloads to fix precision issues with g_sum#95mathomp4 wants to merge 1 commit intofeature/sdrabenh/fix_fvdycore_layout_regressfrom
mathomp4 wants to merge 1 commit intofeature/sdrabenh/fix_fvdycore_layout_regressfrom
Conversation
mathomp4
added
the
0 diff
Member
Author
|
Moving to draft until I can test with "normal" GEOS |
Member
Author
|
I have tested this with GEOSgcm in the "normal" way and it is zero-diff. I then tried a run with: and it ran...but wasn't zero-diff to a non-ADV run. Should it be? (was faster though!) |
Member
Author
|
I also just ran |
Member
Author
|
Closing as pulled in in different way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with @tclune, these seem to be good edits to fix up the
g_sumissue being seen in the CI in GEOS-ESM/FVdycoreCubed_GridComp#262