Adding background error options in 3dvar_cf#746
Adding background error options in 3dvar_cf#746jeromebarre wants to merge 52 commits intodevelopfrom
Conversation
….yaml Co-authored-by: Doruk Ardağ <38666458+Dooruk@users.noreply.github.com>
….yaml Co-authored-by: Doruk Ardağ <38666458+Dooruk@users.noreply.github.com>
…to feature/add-3dvar-cf
| 'geometry': self.interface_model('geometry'), | ||
| 'output': self.interface_model('increment_cs'), | ||
| }, | ||
|
|
There was a problem hiding this comment.
Can you make sure the fix from #743 is incorporated?
There was a problem hiding this comment.
I'm testing this PR right now, and it looks like it's already incorporated in line 65-68. So there's no need to make any changes to this file in this PR.
|
Looks good, I was able to run the suite with these changes. I wanted to point out there's a shift in the residual norms from the develop version to this PR, not sure if that's important This branch -> develop |
mer-a-o
left a comment
mer-a-o
left a comment
There was a problem hiding this comment.
I tested this PR with different options for background error and it's working. Thanks @jeromebarre. My only comment is in src/swell/configuration/jedi/oops/variational3D.py.
Yes this is expected with those changes. |
mranst
added
the
passes tier1
3 participants
Description
This PR adds configurable SABER background-error support for geos_cf by plumbing
saber_central_blockandsaber_outer_blockthrough Swell question defaults, task question registration, JEDI template rendering, and GEOS-CF interface generation. It updates the background error configuration to support bothidentityandbump_nicas(and later other flavors such asdiffusion) central blocks, with optional outer blocks such asstddev_bkg_scaledorstddev_fixed_values(for testing purposes), and updates cycle staging so NICAS files are only linked whenbump_nicasis actually selected.Dependencies
None
Impact
3dvar_cf suite