Skip to content

minor yaml corrections related to computing ensemble prior mean and variance #749

Merged
mranst merged 2 commits intodevelopfrom
feature/ygyu/PR_ens_variance
Mar 26, 2026
Merged

minor yaml corrections related to computing ensemble prior mean and variance #749
mranst merged 2 commits intodevelopfrom
feature/ygyu/PR_ens_variance

Conversation

@metdyn
Copy link
Copy Markdown
Contributor

@metdyn metdyn commented Mar 21, 2026

Description

solves the issue:

Dependencies

Impact

fv3jedi_ensmeanvariance.x output:
geos.prior.mean.20231010_000000z.nc4
geos.prior.variance.20231010_000000z.nc4

cov Ps

fv3jedi_letkf.x output:
geos.analysis.mean.20231010_000000z.nc4
geos.mean-inc.20231010_000000z.nc4

Copy link
Copy Markdown
Contributor

@mer-a-o mer-a-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks @metdyn. I just have a question and a minor suggestion.

Which suite uses fv3jedi_ensmeanvariance.x?

Since calculation of ensemble mean and spread is not limited to prior and can be done for posterior too, would it make sense to change ensemble_latlon_prior_mean_output to ensemble_latlon_mean_output (same for variance)?

Copy link
Copy Markdown
Collaborator

@mranst mranst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mranst mranst added the passes tier1 Add this tag to indicate that the tier1 tests have been activated and passed on github. label Mar 23, 2026
@mranst mranst merged commit 5648bcb into develop Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

passes tier1 Add this tag to indicate that the tier1 tests have been activated and passed on github.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants