Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables comparison tests for 3dvar_cf, same as the other variational suites in swell.
To create a comparison suite, create an override yaml containing at least the following entry:
(these can be the same paths for testing purposes)
then launch
swell create compare_variational_cf -o <override.yaml>The comparison suite checks the jedi log to ensure the
Residual normsare identical between the two experiments. If they are not, the suite will run eva tasks generating plots of comparisons/differences. If you don't have a test case with differing residual norms, you can check out the plots by removing the fail condition for those tasks from theflow.cylcgraph